Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[test]: fix a type hint #4173

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

ZhipengXue97
Copy link
Contributor

Description

Fix a type check warning reported by Pyre@Google, which was outdated after code modifications.

Detail

update the return type of function fix_terminal from bool to str, since it could be str after commit 176e7f7

@fubuloubu fubuloubu enabled auto-merge (squash) July 11, 2024 03:17
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (5067b86) to head (5f470cb).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4173      +/-   ##
==========================================
- Coverage   91.34%   88.32%   -3.03%     
==========================================
  Files         109      106       -3     
  Lines       15606    15247     -359     
  Branches     3432     3367      -65     
==========================================
- Hits        14256    13467     -789     
- Misses        920     1265     +345     
- Partials      430      515      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

interesting, thanks! @ZhipengXue97 are you performing large scale type hint fixes? https://github.com/ZhipengXue97?tab=overview&from=2024-07-01&to=2024-07-30

@ZhipengXue97
Copy link
Contributor Author

@charles-cooper We are trying to develop a tool to update the type hints based on the code modification such as commit, to avoid false positive warnings from type checker, this PR is fixed by our tool based on the previous commit.

@charles-cooper charles-cooper changed the title fix[test]: Type hint Fix chore[test]: fix a type hint Jul 26, 2024
@charles-cooper charles-cooper merged commit 8931e54 into vyperlang:master Jul 26, 2024
156 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants