Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set -e causes kid to fail #13

Open
LordGaav opened this issue Jul 29, 2016 · 2 comments
Open

set -e causes kid to fail #13

LordGaav opened this issue Jul 29, 2016 · 2 comments

Comments

@LordGaav
Copy link

When using kid up, the following output is generated:

$ ./kid up
WARNING: No swap limit support
WARNING: No swap limit support

When adding set -x to the script, the following is outputted:

$ ./kid up
+ '[' up == up ']'
+ start_kubernetes 1.3.2 8080 31999 cluster.local 10.0.0.10
+ local kubernetes_version=1.3.2
+ local kubernetes_api_port=8080
+ local dashboard_service_nodeport=31999
+ local dns_domain=cluster.local
+ local dns_server_ip=10.0.0.10
+ check_prerequisites
+ require_command_exists kubectl
+ command -v kubectl
+ require_command_exists docker
+ command -v docker
+ require_command_exists socat
+ command -v socat
+ docker info
WARNING: No swap limit support
+ '[' 0 '!=' 0 ']'
++ active_docker_machine
++ docker-machine active
++ [[ 1 == 0 ]]
+ '[' -n ']'
+ fix_shared_mount /
+ path=/
+ docker run -it --rm --entrypoint=sh --privileged --net=host -e sysimage=/host -v /:/host -v /dev:/dev -v /run:/run gcr.io/google_containers/hyperkube-amd64:v1.3.2 -c 'nsenter --mount=$sysimage/proc/1/ns/mnt -- mount --make-shared /'
+ docker info
+ egrep -q 'Kernel Version: .*-moby'
WARNING: No swap limit support

It looks like the re-introduction of set -e in 73ed577 causes the script to fail on

kid/kid

Line 45 in 73ed577

docker info | egrep -q 'Kernel Version: .*-moby'
.

Removing the set -e allows kid up to run successfully.

@vyshane
Copy link
Owner

vyshane commented Aug 1, 2016

Okay, I've removed the offending set -e.

@mongrelion
Copy link

If the offending set -e has been removed then I think we can close this issue @vyshane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants