Fix endianess, clean up on the way. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWiederhake
force-pushed
the
develop
branch
3 times, most recently
from
faa69b3
to
66d26ea
Compare
vysheng
added a commit
that referenced
this pull request
Oct 17, 2015
Fix endianess, clean up on the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two options concerning endianess:
portable_endian.hand be done. (It's even highly efficient!) Good: Exists already, can't go wrong that easily. Bad: Lot's of code.BYTE_ORDERto detect it manually. Good: Less code. Bad: Error-prone, not as portable probably.I implemented the first option. If you want me to implement the second option, please give me a good reason for that.