Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add findBy method #2

Merged
merged 9 commits into from
Oct 30, 2018
Merged

Add findBy method #2

merged 9 commits into from
Oct 30, 2018

Conversation

stepanvanzuriak
Copy link
Collaborator

No description provided.

@vzhufk
Copy link
Owner

vzhufk commented Oct 30, 2018

I think that memo should be an option for module, so you can use it, or not even with findBy function. Because not everyone want to store it into memory.
Memo get and set have to be used via adapter. For now it's default memory adapter. For future - redis and etc.

@vzhufk vzhufk merged commit e91f6bb into master Oct 30, 2018
@vzhufk vzhufk deleted the memoize branch November 1, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhufk vzhufk vzhufk approved these changes

@malyuchok malyuchok malyuchok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepanvanzuriak @vzhufk @malyuchok