Merged some aspects into a unified color scheme (rebased) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ The color file now always sets values for both cterm and gui, instead of trying to detect which is being used. This allows, for instance, for starting in terminal vim, and using :gui to start the gui without having to re-run the color command. + The file now inspects the value of &background. If it is 'dark', the hybrid palette is used. If it is 'light', the hybrid-light palette is used. Choice of palette can therefore be toggled via 'set bg=light/dark'. + hybrid-light.vim has been deleted in light of the previous change.
lithammer
changed the title
|
@w0ng what do you think? |
|
👍 How's the progress on this? |
|
It's done from my end, just need @w0ng to take a look at it. |
|
@Renstrom Thanks a lot for tidying this up. Before merging, could you please remove the Also, I think the Spell hilights need merging i.e. the In #30, errors are thrown in the light version because it's attempting to set ctermbg="" for the Spell hilights. |
|
This is what the spelling stuff look like. term
gui
|
|
👍 it's good to see some progress on this!! Thank you. |
w0ng
added a commit
that referenced
this pull request
Sep 27, 2015
Merged some aspects into a unified color scheme (rebased)
|
Awesome thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #9, it was quite messy, but I think it's all there.