Add support for sql-lint #2221
Closed
Add support for sql-lint #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Jan 27, 2019
There was a problem hiding this comment.
Add tests for the new linter and handler. See :help ale-dev.
I think we should use some detection of the filetype for specifically MySQL, if this linter is only for mysql code. We could require the filetype to include mysql, like set filetype=sql.mysql, or we could check if getbufvar(a:buffer, 'current_syntax') is# 'mysql'`, or similar. Have a look through the Plugin files for SQL code that are bundled with Vim itself.
Merged
|
Follow up is here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the MySQL linter, sql-lint.
Thanks!