-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fixer for r based on the styler package #2401
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6b7fce0
Add styler as a new fixer for R files
tvatter 8487dd7
Fix bug
tvatter e7fc7c0
Fix typo
tvatter 9321989
Add to the list of supported tools
tvatter ce91eeb
Add documentation
tvatter d01d645
Test that the custom option is passed
tvatter 0d8cd06
Merge branch 'master' into fixers-styler
tvatter e7961df
fix bracket registry
tvatter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
" Author: tvatter <thibault.vatter@gmail.com> | ||
" Description: Fixing R files with styler. | ||
|
||
call ale#Set('r_styler_executable', 'Rscript') | ||
call ale#Set('r_styler_options', 'tidyverse_style') | ||
|
||
function! ale#fixers#styler#Fix(buffer) abort | ||
return { | ||
\ 'command': 'Rscript --vanilla -e ' | ||
\ . '"suppressPackageStartupMessages(library(styler));' | ||
\ . 'style_file(commandArgs(TRUE), style = ' | ||
\ . ale#Var(a:buffer, 'r_styler_options') . ')"' | ||
\ . ' %t', | ||
\ 'read_temporary_file': 1, | ||
\} | ||
endfunction |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -357,6 +357,7 @@ Notes: | |
* `qmllint` | ||
* R | ||
* `lintr` | ||
* `styler` | ||
* Racket | ||
* `raco` | ||
* ReasonML | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Before: | ||
call ale#test#SetDirectory('/testplugin/test/fixers') | ||
|
||
After: | ||
Restore | ||
|
||
call ale#test#RestoreDirectory() | ||
|
||
Execute(The styler callback should include custom styler options): | ||
let g:ale_r_styler_options = "a_custom_option" | ||
|
||
AssertEqual | ||
\ { | ||
\ 'command': 'Rscript --vanilla -e ' | ||
\ . '"suppressPackageStartupMessages(library(styler));' | ||
\ . 'style_file(commandArgs(TRUE), style = ' | ||
\ . 'a_custom_option)"' | ||
\ . ' %t', | ||
\ 'read_temporary_file': 1, | ||
\ }, | ||
\ ale#fixers#styler#Fix(bufnr('')) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I think you might be missing a
}
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now tests pass, hooray 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed :)