Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navtex: fix and simplify timing recovery logic #34

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

rikvanriel
Copy link
Contributor

navtex: fix and simplify timing recovery logic

The timing recovery logic was changed to an early / late detector a few
years ago in order to make it less sensitive to null crossings, which
are easily thrown off by the fact that mark and space have their own
low pass filters, and the discriminator calculating the envelope for each
separately.

The discriminator output can have mark deviate further from zero than
space, or the other way around, which can shift the null crossings
around in unpredictable ways.

Finding the actual peaks in the discriminator output itself appears
to be a little more predictable. It allows us to get rid of the
accumulator logic, and expand the loop bandwidth so we can now
track the example NAVTEX signal from https://www.sigidwiki.com/wiki/NAVTEX,
which runs about .25% fast, which can be seen from a consistent adjustment
of around -2 samples every 8 bit periods.

The resulting code can still decode signals from the USGS (Honolulu),
Canada (Moise and Chebogue), and Buenos Aires, all of which are much
lower S/N but closer to the nominal baud rate than the example signal.

Signed-off-by: Rik van Riel riel@surriel.com

Dave Tillman and others added 30 commits August 3, 2022 21:25
  * Fixed crash-to-desktop upon Activity (pskreporter) query.
    The associated thread required a qrunner object for
    communication with the main thread but did not have one.
  * Error in query syntax precluded filtering Activity
    by arbitrary grid square
  * Typo in frequency for 30 meter CW put it on the 160 meter band
  * Under some scenarios, clicking on the County combo box button
    in the Log section of the main UI would cause the program to crash.
  * Fixed several edge case behaviors with Combobox widgets
  * Made FC behavior consistent across flapps
  * Changed freq data types to ULL to support higher max freq
  * Adjustments to the N3FJP interface code related to FC changes
  * Additional ULL data type-related changes to log-related functionality
  * No functional changes or bug fixes
  * stub out audio alert and rx monitor functions if Portaudio
    library not present
  * change CAT keying to allow up to 100 WPM on K4.
  * add code to set macro editor to non-modal
  * Add bandwidth lines to waterfall display
  * correct squelch estimation for zero signal, zero noise
  * expand mode state to index both by-mode and by-band
  * mode state includes these parameters:
    . band
    . TX attenuator: default -12.0 dB
    . squelch level: default 30 % of full scale
    . squelch state: default ON
    . afc state: default ON
    . reverse: default OFF
  * save mode-band state variables in mode_state prefs file
  * save global mode state variable in status prefs file
  * rewrite as C++ class, insure compatibility with OS-X Lion gcc
  * convert special characters to HTML5 escape sequence
    in lookup functions
  * correct editor tag entry
  * correction to configuration dialog text
  * Rx audio gain parameter corrected
  * Tx audio fixed, fixed at last
    . ring buffer too small for some modem types
  * add right click to access edit controls
  * replicate the QTH control on the FSQ config panel
  * allow user selectable vumeter scale
    . original audio level scale
    . wsjtx emulation
  * Improved reliability of freq control from fldigi
    when using N3FJP for rig control
  * Updated documentation on N3FJP interface setup
  * fldigi assumes a width and height of the raster widget of > 4 which
    may not always be the case when running in a tiling window manager
    such as i3.  This results in a crash due to an allocation of the
    raster video buffer with a negative width or height.
  * add code to insure Window decoration icon transparency
  * code around inadequate MinGW macro parser
    . compiler fails to correctly parse "%llu" in macro
      statements
  * update to autoconf 2.69
  * update to autoconf 2.71
  * update to gettext 0.21
  * Greek po file update: Haris Andrianos <sv1grb@gmail.com>
  * Polish po file update: Roman Bagiński <sp4jeu@gmail.com>
  * Adjustments to the N3FJP interface code related to FC changes
  * Additional ULL data type-related changes to log-related functionality
  * use identical code as in flrig
  * add '"' to table of valid CW characters
  * No functional changes or bug fixes
Dave Tillman and others added 17 commits January 29, 2023 21:30
  * Improved reliability of freq control from fldigi
    when using N3FJP for rig control
  * Updated documentation on N3FJP interface setup
  * update for compatability with fltk-1.4
  * transfer changes in flrig cwio speed to tx wpm vice
    rx wpm
  * create separate configuration tab
  * maintenance release
  * use of REQ from unregistered thread
  * Maintenance release
  * modify test and action for FL_LEAVE event in frequency
    control widget
  * changed reading system fonts to fonts dialog instantiation
  * correct for Unbuntu window manager
  * Add ability to log to cloud (web) log
  * The header file error.h does not exist in the musl libc.  It
    is safe to just remove it.
  * fix for tx monitoring without an initialized audio device
    . potential for segmentation fault on all target operating
      systems
  * Maintenance release
The timing recovery logic was changed to an early / late detector a few
years ago in order to make it less sensitive to null crossings, which
are easily thrown off by the fact that mark and space have their own
low pass filters, and the discriminator calculating the envelope for each
separately.

The discriminator output can have mark deviate further from zero than
space, or the other way around, which can shift the null crossings
around in unpredictable ways.

Finding the actual peaks in the discriminator output itself appears
to be a little more predictable. It allows us to get rid of the
accumulator logic, and expand the loop bandwidth so we can now
track the example NAVTEX signal from https://www.sigidwiki.com/wiki/NAVTEX,
which runs about .25% fast, which can be seen from a consistent adjustment
of around -2 samples every 8 bit periods.

The resulting code can still decode signals from the USGS (Honolulu),
Canada (Moise and Chebogue), and Buenos Aires, all of which are much
lower S/N but closer to the nominal baud rate than the example signal.

Signed-off-by: Rik van Riel <riel@surriel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants