-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navtex: fix and simplify timing recovery logic #34
Open
rikvanriel
wants to merge
47
commits into
w1hkj:master
Choose a base branch
from
rikvanriel:riel/navtex-peak
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed crash-to-desktop upon Activity (pskreporter) query. The associated thread required a qrunner object for communication with the main thread but did not have one.
* Error in query syntax precluded filtering Activity by arbitrary grid square
* Typo in frequency for 30 meter CW put it on the 160 meter band
* Under some scenarios, clicking on the County combo box button in the Log section of the main UI would cause the program to crash.
* Fixed several edge case behaviors with Combobox widgets
* Made FC behavior consistent across flapps * Changed freq data types to ULL to support higher max freq
* Adjustments to the N3FJP interface code related to FC changes * Additional ULL data type-related changes to log-related functionality
* No functional changes or bug fixes
* stub out audio alert and rx monitor functions if Portaudio library not present
* add code to set macro editor to non-modal
* Add bandwidth lines to waterfall display
* correct squelch estimation for zero signal, zero noise
* expand mode state to index both by-mode and by-band * mode state includes these parameters: . band . TX attenuator: default -12.0 dB . squelch level: default 30 % of full scale . squelch state: default ON . afc state: default ON . reverse: default OFF * save mode-band state variables in mode_state prefs file * save global mode state variable in status prefs file * rewrite as C++ class, insure compatibility with OS-X Lion gcc
* convert special characters to HTML5 escape sequence in lookup functions
* correct editor tag entry
* correction to configuration dialog text
* Rx audio gain parameter corrected * Tx audio fixed, fixed at last . ring buffer too small for some modem types
* add right click to access edit controls * replicate the QTH control on the FSQ config panel
* Improved reliability of freq control from fldigi when using N3FJP for rig control * Updated documentation on N3FJP interface setup
* fldigi assumes a width and height of the raster widget of > 4 which may not always be the case when running in a tiling window manager such as i3. This results in a crash due to an allocation of the raster video buffer with a negative width or height.
* add code to insure Window decoration icon transparency
* code around inadequate MinGW macro parser . compiler fails to correctly parse "%llu" in macro statements
* update to autoconf 2.69 * update to autoconf 2.71 * update to gettext 0.21
* Greek po file update: Haris Andrianos <sv1grb@gmail.com> * Polish po file update: Roman Bagiński <sp4jeu@gmail.com>
* Adjustments to the N3FJP interface code related to FC changes * Additional ULL data type-related changes to log-related functionality
* add '"' to table of valid CW characters
* No functional changes or bug fixes
* Improved reliability of freq control from fldigi when using N3FJP for rig control * Updated documentation on N3FJP interface setup
* update for compatability with fltk-1.4
* transfer changes in flrig cwio speed to tx wpm vice rx wpm
* maintenance release
* use of REQ from unregistered thread
* Maintenance release
* correct for Unbuntu window manager
* Add ability to log to cloud (web) log
* The header file error.h does not exist in the musl libc. It is safe to just remove it.
* fix for tx monitoring without an initialized audio device . potential for segmentation fault on all target operating systems
* Maintenance release
The timing recovery logic was changed to an early / late detector a few years ago in order to make it less sensitive to null crossings, which are easily thrown off by the fact that mark and space have their own low pass filters, and the discriminator calculating the envelope for each separately. The discriminator output can have mark deviate further from zero than space, or the other way around, which can shift the null crossings around in unpredictable ways. Finding the actual peaks in the discriminator output itself appears to be a little more predictable. It allows us to get rid of the accumulator logic, and expand the loop bandwidth so we can now track the example NAVTEX signal from https://www.sigidwiki.com/wiki/NAVTEX, which runs about .25% fast, which can be seen from a consistent adjustment of around -2 samples every 8 bit periods. The resulting code can still decode signals from the USGS (Honolulu), Canada (Moise and Chebogue), and Buenos Aires, all of which are much lower S/N but closer to the nominal baud rate than the example signal. Signed-off-by: Rik van Riel <riel@surriel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navtex: fix and simplify timing recovery logic
The timing recovery logic was changed to an early / late detector a few
years ago in order to make it less sensitive to null crossings, which
are easily thrown off by the fact that mark and space have their own
low pass filters, and the discriminator calculating the envelope for each
separately.
The discriminator output can have mark deviate further from zero than
space, or the other way around, which can shift the null crossings
around in unpredictable ways.
Finding the actual peaks in the discriminator output itself appears
to be a little more predictable. It allows us to get rid of the
accumulator logic, and expand the loop bandwidth so we can now
track the example NAVTEX signal from https://www.sigidwiki.com/wiki/NAVTEX,
which runs about .25% fast, which can be seen from a consistent adjustment
of around -2 samples every 8 bit periods.
The resulting code can still decode signals from the USGS (Honolulu),
Canada (Moise and Chebogue), and Buenos Aires, all of which are much
lower S/N but closer to the nominal baud rate than the example signal.
Signed-off-by: Rik van Riel riel@surriel.com