Add credential schema to vbc #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BenjaminMoe
commented
Feb 9, 2023
BenjaminMoe
commented
- Add Credential Schema
- Inline everything to make it easy to validate
- Require id for validation
- Require proof for validation
BenjaminMoe
requested review from
OR13,
mprorock,
mkhraisha and
nissimsan
as code owners
OR13
approved these changes
Feb 9, 2023
nissimsan
approved these changes
Feb 9, 2023
TallTed
suggested changes
Feb 9, 2023
docs/openapi/components/schemas/credentials/VerifiableBusinessCard.yml
Outdated
Show resolved
Hide resolved
…Card.yml Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
@BenjaminMoe to update based on feeback from @TallTed and merge offline |
mprorock
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.