Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTR minor tweaks #766

Merged
merged 2 commits into from
May 9, 2023
Merged

MTR minor tweaks #766

merged 2 commits into from
May 9, 2023

Conversation

nissimsan
Copy link
Collaborator

Based on review of more real life samples, this:

  1. Adds Lead and Carbon Equivalence chemical analysis
  2. Moves product desc from inspection array to root
  3. Fixes a bad measured value description
  4. Makes steel grade a string instead of array

@nissimsan @TallTed
Update docs/openapi/components/schemas/credentials/MillTestReportCred…
8ff18dd 
…ential.yml

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@mkhraisha mkhraisha merged commit 9c0fe48 into main May 9, 2023
@mkhraisha mkhraisha deleted the mtr-minor-tweaks branch May 9, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@BenjaminMoe BenjaminMoe BenjaminMoe approved these changes

@mkhraisha mkhraisha mkhraisha approved these changes

@OR13 OR13 OR13 approved these changes

@mprorock mprorock Awaiting requested review from mprorock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nissimsan @TallTed @OR13 @mkhraisha @BenjaminMoe