-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proof type issue/present option #197
Conversation
@@ -41,6 +44,7 @@ components: | |||
description: The type of credential status to issue the credential with | |||
example: | |||
{ | |||
"type": "https://w3id.org/security#Ed25519Signature2018", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the question becomes... why is type
a fully qualified URL and assertionMethod
is not. :)
We could go two ways on this -- include an @context
(probably overkill), or require full URLs in options
(probably annoying).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended to use the compact form, for consistency with the other options and existing conventions for proof objects.
@@ -34,6 +37,7 @@ components: | |||
description: The intended domain of validity for the proof. For example website.example | |||
example: | |||
{ | |||
"type": "https://w3id.org/security#Ed25519Signature2018", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended to use the compact form, for consistency.
https://github.com/w3c-ccg/vc-http-api/compare/322fba6..173c26b0df3ca1a1406f7b8d4469ef5f15b3afcb
@clehner I am no longer certain that |
Signature suite Ethereum EIP712 Signature 2021 (proposed work item: w3c-ccg/community#194) does not define a new verification method but only a signing method (proof type), and is meant to be used with existing verification methods
EcdsaSecp256k1VerificationKey2019
orEcdsaSecp256k1RecoveryMethod2020
. For proof creation withvc-http-api
, theverificationMethod
option of the issue/present credential options is then no longer sufficient to identify the type of proof to create, since there is not a one-to-one correspondance of verification method type to proof type. This PR adds a type option for use in situations such as this where there is more than one type of proof that could be issued.Edit: relevant issue #47.
This also could be useful if one wants to choose between using e.g.
Ed25519Signature2018
orEd25519Signature2020
when the issuer/holder is usingdid:key
.