refactor: test suite #94
Conversation
Co-authored-by: Scott Malley <srmalley-sphereon@github.com>
There was a problem hiding this comment.
This looks good to me, although @OR13 is of course better qualified to comment on the depths of the JavaScript code and overall structure.
Danube Tech's endpoints are up, but the Issuer DIDs have changed. I can update that in a separate PR after this is merged. |
| module.exports = [ | ||
| { | ||
| name: "USCIS Permanent Residency Card", | ||
| data: require('./case-1.json') |
There was a problem hiding this comment.
nit: consider recursive load from filesystem, so that new stuff does not need to be manually registered.
| name: "Permanent Residency Card", | ||
| issuerDidMethod: "did:key:", | ||
| linkedDataProofSuite: "Ed25519Signature2018", | ||
| data: require('./case-1.json') |
There was a problem hiding this comment.
nit: consider recursive load from fs instead off manual registration.
| /** | ||
| * Configuration for running the test suite | ||
| */ | ||
| module.exports = [ |
There was a problem hiding this comment.
we probably want to wire these to CI, so that each vendor is shown as passing / failing on each PR, please create an issue to track this requested feature
| @@ -0,0 +1,32 @@ | |||
| module.exports = extractTestSummary = (results) => { | |||
There was a problem hiding this comment.
this structure looks valuable to did core, please open an issue on that suite to track alignment with changes here.
| }); | ||
|
|
||
| return summary.sort((a, b) => | ||
| JSON.stringify(a).localeCompare(JSON.stringify(b)) |
There was a problem hiding this comment.
nit: consider canonicalize instead of stringify.
|
question on merge timeframe - I would like to start writing docs around the tests so that we can get them in prior to impending code freeze - how long are we waiting to get this merged? |
|
Apologies on this, really busy week, I am working on some updates but don't expect to have them complete for a few days, perhaps we should merge and I will file a separate PR to address the outstanding issues. |
|
multiple reviews, open for 7 days... merging. |
This PR starts the refactor of the current plugfest test suite over to a new package that features a more generalized testing infrastructure that is runnable on an HTTP server to allow for on demand testing of register vendor APIs. Still very much a WIP and is based on the hard work of @OR13 on the did-core-test-suite.
Changes of note
Whilst converting over to this format I was only able to get results from Digital Bazaars and Transmutes APIs at present, the rest appeared to be offline?
I still have quite a bit to do on this PR, but looking for early feedback primarily from @OR13 due to his familiarity with it.