Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix _includes link, add note. #273

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jun 7, 2019

"includes" is reserved word in WebIDL, so a method with that name
needs to be escaped with a leading underscore in IDL fragments.
This confuses Bikeshed (speced/bikeshed#1489) so manually
correct the link. Also, the 2.0 version of the IDB spec had a note
which gave context for this; transplant that to the 3.0 version.

Resolves #270


Preview | Diff

"includes" is reserved word in WebIDL, so a method with that name
needs to be escaped with a leading underscore in IDL fragments.
This confuses Bikeshed (speced/bikeshed#1489) so manually
correct the link. Also, the 2.0 version of the IDB spec had a note
which gave context for this; transplant that to the 3.0 version.

Resolves #270
@inexorabletash
Copy link
Member Author

@mkruisselbrink - please take a look?

Copy link

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@inexorabletash inexorabletash merged commit 02f4c89 into master Jun 7, 2019
@inexorabletash inexorabletash deleted the includelink branch March 27, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDBKeyRange.includes or IDBKeyRange._includes?
2 participants