Align Accelerometer interface with the Generic Sensor API #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssiko
reviewed
Feb 2, 2017
index.bs
Outdated
|
|
||
| The Accelerometer has a <a>default sensor</a>, | ||
| which is the device's main accelerometer sensor. | ||
| The accelerometer's associated {{Sensor}} is the {{Accelerometer}} class. |
There was a problem hiding this comment.
Other specs use this boilerplate definition:
The accelerometer's associated {{Sensor}} subclass is the {{Accelerometer}} class.
Should perhaps align with that.
anssiko
reviewed
Feb 2, 2017
index.bs
Outdated
| interface represents the <a>acceleration</a> along Z-axis. | ||
| By default, accelerometer sensor provides <a>acceleration</a> information including the effect of the gravity force. | ||
| In cases when <a>linear acceleration</a> information is required, {{AccelerometerOptions}} dictionary | ||
| must include an [=map/entry=] with a [=map/key=] that is "includesGravity" and its [=map/value=] must be a |
There was a problem hiding this comment.
A more concise form would be:
[=map/entry=] whose [=map/key=] is "includesGravity" and whose value is false.
"Whose" is commonly used language in specs, type is defined in IDL so can drop that from prose.
|
LGTM with comments. After @pozdnyakov's review you can merge this. |
This patch aligns Accelerometer interface with the latest changes in Generic Sensor API. AccelerometerReading interface is removed and sensor reading values are exposed on main Accelerometer interface using "latest reading" terminology from Generic Sensor API [1]. [1] https://w3c.github.io/sensors/#latest-reading
alexshalamov
force-pushed
the
gh-pages
branch
from
78803dd
to
a1b7d85
Compare
pozdnyakov
approved these changes
Feb 2, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns Accelerometer interface with the latest changes in Generic Sensor API.
AccelerometerReading interface is removed and sensor reading values are exposed on main
Accelerometer interface using "latest reading" terminology from Generic Sensor API [1].
[1] https://w3c.github.io/sensors/#latest-reading