Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github action to run prettier #94

Closed
wants to merge 2 commits into from
Closed

feat: github action to run prettier #94

wants to merge 2 commits into from

Conversation

pkra
Copy link
Member

@pkra pkra commented May 15, 2023

Runs pretter on PRs to the main branch;
keeping to the defaults for now.

pkra and others added 2 commits May 15, 2023 21:51
Runs pretter on PRs to the main branch;
keeping to the defaults for now.
@pkra pkra requested review from jnurthen and spectranaut May 15, 2023 19:55
@pkra
Copy link
Member Author

pkra commented May 15, 2023

@jnurthen @spectranaut This feels simpler to me than #49, which only reports errors and expects people to fix their PRs to pass linting rules they might not know much about.

What do you think?

@pkra pkra mentioned this pull request May 16, 2023
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do really like this, a lot. Do you want to add this to all the spec repos directly? Is the PR here just demonstration, because aren't we working towards retiring this repo?

@pkra
Copy link
Member Author

pkra commented Jun 26, 2023

As per the last editors meeting, we want to try this approach for other repositories (but not here).

@pkra pkra closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants