Modal Dialog Example: Dialogs underneath other dialogs are not grayed out #523
Assignees
Labels
bug
Code defects; not for inaccurate prose
Example Page
Related to a page containing an example implementation of a pattern
Milestone
Comments
mcking65
added
bug
Merged
|
You can see and test Evan's proposed fix in his repo here: Compare to what is in master now: Given the amount of back and forth we had on this example, I want to be thorough in our testing before merging. If you find problems with the fix, please comment in pull #549. |
mcking65
moved this from Next Steps
to In Progress
in Dialog Patterns and Examples Development Project
|
Comments added in pull #549. |
Dialog Patterns and Examples Development Project
automation
moved this from In Progress
to Complete
Dec 12, 2017
mcking65
pushed a commit
that referenced
this issue
Dec 12, 2017
For issue #523, add a background layer behind each dialog to grey out everything underneath. Changes also include: * minor editorial revisions to intro * replace tabs with spaces * cleanup whitespace * rename ID used on dialog container * wrap dialogs in individual backdrop elements when they're active * remove unused dialog_layer references * use more aria selectors * simpler backdrop styles * fix indent * fullscreen on small screens * Remove unsupported pseudo-element that breaks a selector on some browsers * keep DOM in place once backdrop has been added
|
Fixed with commit fdf51a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the modal dialog example,
when a dialog appears on top of another dialog, the lower z dialog is not grayed out and is not inert.
For example, open the "add delivery address" dialog. Then activate the "Verify Address" button. Then, activate the "accepting an alternative form" button, which opens the "end of the road" dialog. When the "end of the road" dialog is displayed, the underlying content from the "verify address" dialog is not grayed out and is still active.
The lower z dialog should always be grayed when another modal is opened on top of it. And clicking outside the currently active dialog should either do nothing or cancel the currently active dialog.
This was raised by @annabbott in a comment on issue 503.
The text was updated successfully, but these errors were encountered: