Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA 1.1 Combobox Examples: Use for attribute on label element instead of aria-labelledby on input element #542

Closed
mcking65 opened this issue Nov 27, 2017 · 0 comments
Closed

ARIA 1.1 Combobox Examples: Use for attribute on label element instead of aria-labelledby on input element #542

mcking65 opened this issue Nov 27, 2017 · 0 comments
Assignees
@sh0ji
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Milestone
1.1 APG Release 2

Comments

@mcking65
Copy link
Contributor

mcking65 commented Nov 27, 2017 •
edited
Loading

Per comment from Evan in issue 496,
since the text input of the comboboxes is made from a native input element, it is valid to use the for attribute on the label element to label the input. This enables mouse users to click the label to focus the input. For the text input, remove aria-labelledby and add for to the label to refer to the text input. Do this for both:
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy labels Nov 27, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Nov 27, 2017
@mcking65 mcking65 added good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue labels Nov 27, 2017
@sh0ji sh0ji self-assigned this Jun 27, 2018
@sh0ji sh0ji mentioned this issue Jun 27, 2018
Merged
mcking65 pushed a commit that referenced this issue Jul 11, 2018
@sh0ji @mcking65
ARIA 1.1 Combobox Examples: Use for attribute on label element inst…
72f4bb2 
…ead of aria-labelledby on `input` element (pull #746)

Resolve issue #542 by making following changes to both pages containing aria 1.1 combo examples:
* Removing aria-labelledby from input
* Adding for attribute to label element to reference input
* Updating documentation table
@mcking65 mcking65 mentioned this issue Jul 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh0ji sh0ji

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Projects
None yet
Milestone
1.1 APG Release 2
Development

No branches or pull requests
2 participants
@mcking65 @sh0ji