-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit allowed roles for aria-expanded #1026
Comments
(chair hat off for comments below) listbox: if we could get agreement on this it might be a simpler mechanism to create a select than we currently have. I'd be in favour of investigating this as a simplification to current techniques all of which are unsatisfactory IMO gridcell/rowheader/columnheader Pivot tables? It really is the cell you are collapsing/expanding in this case not a button inside it. Logically to me it should be on the cell itself. row I think I agree we should limit this to rows in treegrids. |
@jnurthen those are interesting points! I'd be happy to do some more investigation for some of them (commented below):
Thanks! |
I revisited
|
After talking with @mcking65, I wanted to revisit this with an addition he brought up --
|
|
We added expanded to listbox after our last f2f in Toronto as a potential solution to custom select@size=1. At that time, we didn't have the support for making needed changes to combobox to solve the select@size=1 issue and were hunting for other approaches. Our experience with collapsable listbox in APG surfaced some critical shortcomings with that approach, e.g., you can't mark a button that represents a collapsed listbox required. Now, we have complete resolution of that issue with the ARIA 1.2 combobox changes and there is no need for expanded on listbox. We could deprecate expanded on listbox. Then, we could either warn against using that pattern in APG and point people to the select-only combobox or remove the collapsable listbox example completely. |
@smhigley please move to 1.4 if you will not have time in the 1.3 timeframe |
I'd like to at least remove the listbox aria-expanded attribute + aria-practices example in 1.3 :) |
@smhigley |
There is currently no meaningful use for aria-expanded on a listbox. Therefore it should be removed |
The APG example has since been removed. I think now the only role from the original list I would still like I can make a PR for that, and get this rolling again |
After #681, it looks like the current roles that support aria-expanded are:
Also inherited into:
I was curious about the use cases for the following roles specifically:
application
Similar to
document
, I'm not sure when it would make sense to give the application root itself aria-expandedlistbox
I often see confusion around how to properly implement a custom
<select>
, and one of the common patterns is a<div role="listbox" tabindex="0" aria-expanded="true/false">
. I haven't run into any indication that this is a supported pattern, and I've run into some support issues with it (though more investigation would be needed if it is desired). If that's not an accepted pattern, I think it'd make sense to not support listbox. Some examples where you can see the listbox used as<select>
in the wild:gridcell
I'm less sure about this one, but it seems like a better experience to have a button nested in a grid cell when it's desirable to trigger an expanded element. Is there a use case for having
aria-expanded
on a grid cell that isn't covered by a button?rowheader / columnheader
Similar to gridcell, is there a use case for having
aria-expanded
directly on a row or column header rather than having a child button?row
I know this is valid in a treegrid, but I've run into instances of it being added to a row in a table or grid (e.g. for a grid row that has some sort of supplemental content that visually appears below the row). Using
aria-expanded
on a row doesn't seem like the proper approach for those use case, so if treegrid > row is really the only allowed case, perhaps the documentation could be edited to make that more clear?The text was updated successfully, but these errors were encountered: