Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rowgroup really support name from: contents? #896

Closed
joanmarie opened this issue Feb 1, 2019 · 7 comments
Closed

Should rowgroup really support name from: contents? #896

joanmarie opened this issue Feb 1, 2019 · 7 comments
Assignees
Milestone

Comments

@joanmarie
Copy link
Contributor

At the present time, rowgroup supports name from: contents. This strikes me as a bad idea: Concatenating a bunch of cells together and returning that as the name means screen readers will spew out noise each time focus changes to a rowgroup. Unless, of course, I'm missing something. In which case, please enlighten me. 😄

@joanmarie
Copy link
Contributor Author

For now I'm assuming that I'm not missing anything. That way, if I luck out, we can merge the change into master. (We'll still need tests.)

joanmarie added a commit that referenced this issue Feb 7, 2019
@joanmarie
Copy link
Contributor Author

Merged into master. Needs tests before we can merge into stable.

@aleventhal
Copy link
Contributor

aleventhal commented Feb 7, 2019 via email

@joanmarie
Copy link
Contributor Author

@aleventhal: Thanks for the note. But I'm afraid I'm not sure what, if anything, you'd like us to do in response. Please clarify.

@aleventhal
Copy link
Contributor

aleventhal commented Feb 7, 2019 via email

@joanmarie
Copy link
Contributor Author

Perhaps you could raise your point on the mailing list and/or open a new issue. I find it interesting that Chrome does this optimization. I don't know if there are cases when Chrome shouldn't and/or if we want to address that in the spec as a "user agents MAY ...". But this issue here is strictly about rowgroup.

Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jun 26, 2019

The current editor's draft now says

Name From: author

So, assuming I didn't miss something, this issue is fixed. Please reopen if I did miss something. :)

cc @mcking65

@zcorpan zcorpan closed this as completed Jun 26, 2019
jnurthen pushed a commit that referenced this issue Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants