-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should rowgroup really support name from: contents? #896
Comments
For now I'm assuming that I'm not missing anything. That way, if I luck out, we can merge the change into master. (We'll still need tests.) |
Merged into master. Needs tests before we can merge into stable. |
Related note: row also supports names from contents, which is really only
important if it's focusable (e.g. in a table grid). In Chrome we decided to
make an optimization and not compute the name from contents in unfocusable
rows, because it would be expensive in very large tables.
Aaron
…On Thu, Feb 7, 2019 at 2:08 PM joanmarie ***@***.***> wrote:
Merged into master. Needs tests before we can merge into stable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUAZt3WlO8u_bZQUxHt1LejiYCTfzabks5vLHmdgaJpZM4afMbI>
.
|
@aleventhal: Thanks for the note. But I'm afraid I'm not sure what, if anything, you'd like us to do in response. Please clarify. |
It's informational in case you wanted to do something with it.
…On Thu, Feb 7, 2019, 5:25 PM joanmarie ***@***.***> wrote:
@aleventhal <https://github.com/aleventhal>: Thanks for the note. But I'm
afraid I'm not sure what, if anything, you'd like us to do in response.
Please clarify.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUAZvfYzs26wNBbvFUgydByS8VIRh0Dks5vLKfmgaJpZM4afMbI>
.
|
Perhaps you could raise your point on the mailing list and/or open a new issue. I find it interesting that Chrome does this optimization. I don't know if there are cases when Chrome shouldn't and/or if we want to address that in the spec as a "user agents MAY ...". But this issue here is strictly about rowgroup. Thanks! |
The current editor's draft now says
So, assuming I didn't miss something, this issue is fixed. Please reopen if I did miss something. :) cc @mcking65 |
At the present time, rowgroup supports name from: contents. This strikes me as a bad idea: Concatenating a bunch of cells together and returning that as the name means screen readers will spew out noise each time focus changes to a rowgroup. Unless, of course, I'm missing something. In which case, please enlighten me. 😄
The text was updated successfully, but these errors were encountered: