Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise Owned Element term & Required Context Role #1213

Closed
wants to merge 8 commits into from
Closed

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 13, 2020

This PR aims to close #1161 for ARIA 1.2.

It expands the definition of "owned element" to mention the concept of specific required context roles.

Required Context Role was revised to indicate there are "...no other intermixed containing elements with non-presentational roles" that separate the role from its required context role.

Valid and invalid examples were added to this section to further demonstrate.

Other issues/PRs such as #1162 will help further clarify how owned elements may need to be setup.

This update touches on the topic raised in issue #748, which is marked for 1.3.... though I would say this PR does not "solve" that issue... it at least might help clarify things a bit prior to additional work needing to be done for 1.3.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 20, 2021, 10:59 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

Navigation timeout of 27999 ms exceeded

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

expands to mention that an owned element can require specific required context roles
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this improvement. Just found a little edge case I think isn't clear (at least it wasn't to me).

index.html Outdated Show resolved Hide resolved
@jnurthen
Copy link
Member

build seems to be failing due to w3c/spec-generator#284

common/terms.html Outdated Show resolved Hide resolved
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good!

common/terms.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
common/terms.html Outdated Show resolved Hide resolved
- fix example style for respec
- merge 2 examples into 1 and add comments
Also made a few editorial changes.
@carmacleod carmacleod marked this pull request as draft December 17, 2020 16:55
@carmacleod
Copy link
Contributor

carmacleod commented Dec 17, 2020

@aleventhal @jnurthen @curtbellew @WilcoFiers
I have marked this as Draft so that it does not get accidentally merged before moving the definitions over to aria-common, however I believe this PR is ready for final review.

@aleventhal I would particularly like your review to ensure that I addressed your concern about split ownership... without making the definitions too convoluted to read... :)

Preview links:

  1. Definition of Owned element
    • this definition has changed slightly to explicitly disallow split ownership
    • a new sentence points to Owning element definition and the definition of the Required Context Role characteristic
  2. New definition for Owning element
    • final sentence points to Owned element definition and the definition of the Required Owned Elements characteristic
  3. Updated definition of Required Context Role

Base automatically changed from master to main January 20, 2021 22:59
@@ -136,11 +136,11 @@
</dd>
<dt><dfn data-lt="owned element|owned|owned element's|owned elements">Owned Element</dfn></dt>
<dd>
<p>An 'owned element' is any <abbr title="Document Object Model">DOM</abbr> descendant of the <a>element</a>, any element specified as a child via <pref>aria-owns</pref>, or any <abbr title="Document Object Model">DOM</abbr> descendant of the owned child.</p>
<p>An 'owned element' is any <abbr title="Document Object Model">DOM</abbr> descendant of the <a>element</a> unless the <abbr title="Document Object Model">DOM</abbr> descendant or any of its ancestors is the target of an <pref>aria-owns</pref> relation, any element specified as a child via <pref>aria-owns</pref>, or any <abbr title="Document Object Model">DOM</abbr> descendant of the owned child. 'Owned elements' can have specific <a href="#scope">required context roles</a> in relation to their <a class="termref" href="#dfn-owning-element">owning elements</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or any of its ancestors is the target of an aria-owns relation

I don't understand this restriction. Why is it problematic if an "aria-owned" element's parent is already "aria-owned"?

or any DOM descendant of the owned child

Are elements owned by the owned child owned?

@carmacleod
Copy link
Contributor

@pkra

or any of its ancestors is the target of an aria-owns relation

I don't understand this restriction. Why is it problematic if an "aria-owned" element's parent is already "aria-owned"?

That was my attempt to wordsmith @aleventhal's comment #1213 (comment).
If you can think of a clearer way to say it, please let me know.

or any DOM descendant of the owned child

Are elements owned by the owned child owned?

Heh, I bet you can't say that 5 times fast. ;)
Anyhow, I think the answer is 'yes'. :)

@pkra
Copy link
Member

pkra commented Mar 9, 2021

Thanks @carmacleod .

That was my attempt to wordsmith @aleventhal's comment #1213 (comment).
If you can think of a clearer way to say it, please let me know.

Right. I didn't get this stronger restriction from @aleventhal's comment - only that elements which are aria-owned by another element are no longer owned by their DOM ancestors.

However, it seems to be what Chrome does: I modifed Aaron's example from that comment at https://codepen.io/pkra/pen/GRNYLqJ so that there's another element aria-owning a grandchild of the aria-owned element. In Chrome, the ownership of the grandchild does not change.

@scottaohara
Copy link
Member Author

i'm going to close (but not delete) this PR, since i think Sarah's work makes this irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent use of "owned by"
6 participants