Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve wording for braille patterns #1287

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

pkra
Copy link
Member

@pkra pkra commented Jun 9, 2020

Resolves #1232

Depends on w3c/aria-common#45


Preview | Diff

@pkra pkra added the ARIA 1.3 label Jun 18, 2020
@pkra pkra added this to the ARIA 1.3 milestone Jun 18, 2020
Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current working is confusing, Part of specification says " not contain any characters in Unicode Braille Patterns ". Is there a reason we are not using "must not" or "should not"?

It seems clearer to say:
"The value of aria-braillelabel must (or should) not contain any Unicode Braille characters or values that result in no dots being rendered (e.g. Braille Pattern dots-0).

Then later it says the Braille should be translated by the assistive technology if not a Unicode Braille Pattern, So two things here, in general we have not been giving any direction to assistive technology developers and it would seem to be obvious to them not to translate the Unicode Braille characters if they found them.

@pkra
Copy link
Member Author

pkra commented Jun 18, 2020

@jongund wrote:

I think the current working is confusing, Part of specification says " not contain any characters in Unicode Braille Patterns ". Is there a reason we are not using "must not" or "should not"?

It is a SHOULD (not) - the list is preceded by "authors SHOULD also ensure that". This matches the way aria-label and aria-roledescription talk about these things.

It seems clearer to say: [...]

The current version took a lot of iterations to arrive at. Personally, I'd suggest to keep it as is.

in general we have not been giving any direction to assistive technology developers

The current version reflects feedback from AT developers.

@pkra
Copy link
Member Author

pkra commented Jun 18, 2020

Thanks @jongund! (For what it's worth, I think there's a good chance we'll see another iteration before 1.3 is finalized, e.g., implementation feedback.)

@pkra
Copy link
Member Author

pkra commented Jun 18, 2020

Also thanks @sinabahram!

@pkra
Copy link
Member Author

pkra commented Jun 25, 2020

@jnurthen this is also ready but depends on w3c/aria-common#45 (which is basically ready).

@jnurthen jnurthen merged commit 42417ce into w3c:master Nov 5, 2020
@pkra pkra deleted the unicodebraille branch November 5, 2020 18:02
@pkra pkra mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve sentence on braille patterns
5 participants