Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract roles remove 'name from' #1667

Merged
merged 1 commit into from Jan 20, 2022
Merged

abstract roles remove 'name from' #1667

merged 1 commit into from Jan 20, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Dec 21, 2021 •
edited by pr-preview bot

closes #1436, removes name from entries from the abstract role characteristic tables.

Preview | Diff

@scottaohara
abstract roles remove 'name from'
0afa70e 
closes #1436, removes name from entries from the abstract role characteristic tables.
@jnurthen jnurthen requested review from jnurthen and pkra January 6, 2022 18:27
@jnurthen jnurthen added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jan 6, 2022
@pkra pkra self-assigned this Jan 12, 2022
@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@pkra pkra removed their assignment Jan 13, 2022
carmacleod
carmacleod approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 This is a good fix.
Thanks, @scottaohara!
And thanks @JAWS-test for reporting.

@pkra pkra merged commit 157d711 into main Jan 20, 2022
@pkra pkra deleted the scottaohara-1436 branch January 20, 2022 18:20
github-actions bot added a commit that referenced this pull request Jan 20, 2022
@scottaohara @github-actions
abstract roles remove 'name from' (#1667)
212bc28 
SHA: 157d711
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to pkra/aria that referenced this pull request Apr 29, 2022
@scottaohara @github-actions
abstract roles remove 'name from' (w3c#1667)
b4593e2 
SHA: 157d711
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Jul 14, 2022
@scottaohara @pkra
abstract roles remove 'name from' (#1667)
4c0c271 
closes #1436, removes name from entries from the abstract role characteristic tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkra pkra pkra approved these changes

@carmacleod carmacleod carmacleod approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

Assignees
No one assigned
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

"Name From" not useful for abstract roles
4 participants
@scottaohara @pkra @carmacleod @jnurthen