Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict aria-owns on roles with children presentational #1812

Merged
merged 4 commits into from
Feb 22, 2024
Merged

restrict aria-owns on roles with children presentational #1812

merged 4 commits into from
Feb 22, 2024

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Sep 20, 2022 •
edited by pr-preview bot
Loading

Fixes #1760

Preview | Diff

scottaohara
scottaohara approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions. otherwise approving

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@jnurthen @scottaohara
Add period
2f3c7ce 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@jnurthen @scottaohara
add period to sentence
0fdaccf 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@pkra
Copy link
Member

pkra commented Sep 23, 2022

@jnurthen @spectranaut in the new process, do we require author tooling support (e.g., validators) before merging?

@pkra pkra added the clarification clarifying or correcting language that is either confusing, misleading or under-specified label Sep 23, 2022
@pkra pkra self-assigned this Sep 23, 2022
@jnurthen
Copy link
Member Author

Needs test file

@pkra pkra added this to the ARIA 1.3 milestone Jun 28, 2023
@pkra pkra assigned jnurthen and unassigned pkra Nov 6, 2023
@pkra
Copy link
Member

pkra commented Nov 6, 2023

@jnurthen I rebased (to update the paragraph before the first change). But then I realized this was still waiting for a test -- so assigning it back to you.

@jnurthen jnurthen merged commit e88317c into main Feb 22, 2024
2 of 3 checks passed
@spectranaut spectranaut mentioned this pull request Feb 22, 2024
Open
@spectranaut
Copy link
Contributor

Made a backlog issue for the validator test: #2127

github-actions bot added a commit that referenced this pull request Feb 22, 2024
@jnurthen @github-actions
Restrict aria-owns on roles with children presentational (#1812)
f4a4dd5 
SHA: e88317c
Reason: push, by jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@JAWS-test JAWS-test mentioned this pull request Feb 23, 2024
Open
@pkra pkra deleted the jnurthen/issue1760 branch February 23, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

@pkra pkra pkra approved these changes

@Jaunita-George Jaunita-George Jaunita-George approved these changes

Assignees

@jnurthen jnurthen

Labels
Author Tests clarification clarifying or correcting language that is either confusing, misleading or under-specified
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

restrict aria-owns on roles with children presentational
5 participants
@jnurthen @pkra @spectranaut @scottaohara @Jaunita-George