Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fixing links to APG and the naming of the APG document in text. #1982

Merged
merged 6 commits into from
May 2, 2024
Merged

Editorial: Fixing links to APG and the naming of the APG document in text. #1982

merged 6 commits into from
May 2, 2024

Conversation

MarioBatusic
Copy link
Contributor

@MarioBatusic MarioBatusic commented Jul 18, 2023 •
edited by pr-preview bot
Loading

  1. Changed links for APG in the script config.
  2. Updated link texts for referencing the APG document in text.

Preview | Diff

@MarioBatusic MarioBatusic changed the title Fixing links to APG and the naming of the APG document in text. Editorial: Fixing links to APG and the naming of the APG document in text. Jul 20, 2023
spectranaut
spectranaut requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm unfortunately there are some unrelated changes that got stuck in the PR, it looks like a revert of the changes that where landed here: #1945

Is this something you can fix @MarioBatusic ? It will be a little tricky to get those changes out of your commit.

@MarioBatusic
Copy link
Contributor Author

MarioBatusic commented Jul 25, 2023 via email

@MarioBatusic
Copy link
Contributor Author

So, now I think I have repaired the PR error. Please merge it.

@pkra pkra added this to the ARIA 1.3 milestone Aug 8, 2023
spectranaut
spectranaut approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake when handling the merge conflict, I'll fix and this is good to go!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@spectranaut spectranaut merged commit 4db9a66 into main May 2, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request May 2, 2024
@MarioBatusic @github-actions
Editorial: Fixing links to APG and the naming of the APG document in …
16f7cc7 
…text. (#1982)

SHA: 4db9a66
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut approved these changes

@daniel-montalvo daniel-montalvo Awaiting requested review from daniel-montalvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.
3 participants
@MarioBatusic @spectranaut @pkra