Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove group as allowed child of tree #2094

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Dec 17, 2023

Closes #2014

Removes group as an allowed accessibility child of tree to fix inconsistency with definition of treeitem. Direct children of tree can only be parent nodes or end nodes. Leaf nodes must be a child of a group that is a child of a parent node treitem. Even in a virtualized tree, if the elements that represent the ancestry of rendered nodes were not present in the DOM, the tree would be inoperable.

PR tracking

Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.

  • Related Core AAM Issue/PR:
  • Related AccName Issue/PR:
  • Related APG Issue/PR:
  • Any other dependent changes?

Implementation tracking

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?

Preview | Diff

@giacomo-petri
Copy link
Contributor

Since I approved the PR without adding any notes (and changes seem great based on the rationale of #2315), I'm assuming I mistakenly applied the agenda label to the wrong GitHub PR. Now, it would be interesting to figure out where I missed applying the agenda label... 🥲

@spectranaut spectranaut removed the Agenda label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treeitem scope should allow group with accessibility parent tree
7 participants