Monorepo: html-aam PR 540 #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this text change is to clarify that a list item that is still a child of a list, but has intervening generic elements should still be exposed as a listitem.
e.g.,
```
<li>with no list ancestor = generic</li>
<ul>
<div> <!-- invalid html, but SHOULD be ignored since generic -->
<li> since this has 'accessibility parent' of list, it should remain exposed as a list item </li>
</div>
</ul>
```
Co-authored-by: Valerie Young <spectranaut@gmail.com>
|
As per discussion, it's unclear if it's worth keeping this kind of history when we end up squashing anyway. I'll make another test off a different html-aam PR where I just copy&paste the PR's current files. |
|
A day later and we're leaning more towards including the history as much as we can. |
|
Closing this. It's easier to start fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick test for w3c/html-aam#540