Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Delete gitattributes, gitignore, pr-preview, readme, and other unwanted files for this monorepo #2289

Closed
wants to merge 1 commit into from

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Jul 19, 2024

No description provided.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 9b5b552
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/669a75b12bdcf00008e0bd2a
😎 Deploy Preview https://deploy-preview-2289--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@spectranaut
Copy link
Contributor

Actually, I think we left most of these files on purpose. The various specs might want to keep their READMEs, maybe we should update them to be more useful. And I assume the editors had the git-ignores for a reason, and these can be file specific. The pr-previews should go though, and probably the .gitattributes -- I'm curious what other editors think though.

@pkra
Copy link
Member

pkra commented Jul 19, 2024

My initial reaction was "let's keep the readme's" - but I really don't have strong feelings about this.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping the READMEs, @daniel-montalvo, and deleting everything else?

@spectranaut spectranaut changed the title Delete gitattributes, gitignore, pr-preview, readme, and other unwanted files for this monorepo Editorial: Delete gitattributes, gitignore, pr-preview, readme, and other unwanted files for this monorepo Aug 19, 2024
@spectranaut spectranaut added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Aug 19, 2024
@daniel-montalvo
Copy link
Contributor Author

Will update accordingly, @spectranaut

@daniel-montalvo
Copy link
Contributor Author

I am closing this without merging. This is not causing any issues now, and could potentially cause problems for some editors according to Val's comment above

If there's updates needed for these files we could open new PRs for them as we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants