Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about password role #396

Merged
merged 3 commits into from
Jun 10, 2016
Merged

Add warning about password role #396

merged 3 commits into from
Jun 10, 2016

Conversation

ZoeBijl
Copy link

@ZoeBijl ZoeBijl commented Jun 2, 2016

Add warning about password role usage as accepted in June 2nd's ARIA call.

This is awaiting CfC

@ZoeBijl ZoeBijl added the ARIA label Jun 2, 2016
@joanmarie
Copy link
Contributor

Thanks for doing this. After any other language changes are made, could you please make the whitespace and element placement of the new paragraph consistent with all the other paragraphs in the spec? While I don't like the entire-paragraph-as-a-line thing we currently do, and plan to reformat the whole spec after we branch and separate repos, I hate inconsistency even more. ;)

@ZoeBijl
Copy link
Author

ZoeBijl commented Jun 2, 2016

I feel you, it's done.

@joanmarie joanmarie merged commit 3847a8e into master Jun 10, 2016
@ZoeBijl ZoeBijl deleted the password-warning branch June 11, 2016 12:27
michael-n-cooper pushed a commit that referenced this pull request Jan 10, 2018
* Add warning about password role

* Make password warning note use warning styling

* Make whitespace consistent
pkra pushed a commit that referenced this pull request May 20, 2024
* allow combobox role on button element
* add combobox to input type=button
* add role=checkbox to input type=button allowances
* update changelog

closes #375
pkra pushed a commit that referenced this pull request May 20, 2024
* Add warning about password role

* Make password warning note use warning styling

* Make whitespace consistent
pkra pushed a commit that referenced this pull request May 21, 2024
* Add warning about password role

* Make password warning note use warning styling

* Make whitespace consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants