[Core AAM] Remove RELATION_POPUP_FOR from ATK/AT-SPI mappings of aria-haspopup #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-haspopup This mapping was added during the 1.1 cycle. And while it is correct in terms of platform expectations, the ARIA spec provides no means through which user agents could reliably implement this.
klown
reviewed
Mar 20, 2017
| @@ -3397,12 +3392,13 @@ | |||
| <section> | |||
| <h2>Substantive changes since the <a href="http://www.w3.org/TR/2015/WD-core-aam-1.1-20151119/">last public working draft</a></h2> | |||
| <ul> | |||
| <li>14-Mar-2017: Undid the 1.1 addition of RELATION_POPUP_FOR to ATK/AT-SPI mappings of aria-haspopup. While the addition is correct in terms of platform expectations, the ARIA spec provides no means through which user agents could reliably implement this.</li> | |||
There was a problem hiding this comment.
@joanmarie how about "Removed" instead of "Undid", since it's the opposite of "Added"?
klown
reviewed
Mar 20, 2017
| <li>20-Jan-2017: Added AX API mappings for aria-colcount, aria-colspan, aria-colindex, aria-rowcount, aria-rowindex, and aria-rowspan.</li> | ||
| <li>07-Dec-2016: Added UIA mappings for roles feed, figure, and term, and for aria-colcount, aria-colspan, aria-colindex, aria-rowcount, aria-rowindex, aria-rowspan, and aria-details. Added UIA Range Value Pattern for range related roles scrollbar, slider, and spinbutton.</li> | ||
| <li>24-Oct-2016: Changed name of IA2 object property name for aria-placeholder to "placeholder-text" (was "placeholder").</li> | ||
| <li>04-Oct-2016: Add reverse relationships for aria-details and aria-errormessage on platforms MSAA/IA2 and ATK/ATSPI</li> | ||
| <li>03-Oct-2016: Added aria-roledescription mappings for empty and whitespace strings as well as error handling text.</li> | ||
| <li>12-Sep-2016: Added RELATION_POPUP_FOR to ATK/AT-SPI mappings of aria-haspopup, for ARIA 1.1.</li> |
There was a problem hiding this comment.
@joanmarie I think this removal is okay since the change log entry was never part of a published working draft. The latest TR is:
https://www.w3.org/TR/core-aam-1.1/#changelog
But, just in case, @michael-n-cooper: is removal of a previously noted change allowed?
|
@joanmarie I've merged in your changes. Take a look, and if it matches your expectations, feel free to close this pull request. Changes: Rawgit: |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mapping was added during the 1.1 cycle. And while it is correct in terms
of platform expectations, the ARIA spec provides no means through which user
agents could reliably implement this.