ISSUE-715: Removing unused glossary terms deletes only the term. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function that removes unused glossary terms is removing only the term, <dt>, but not the actual definition, <dd>. As a result the <dd> text appears to be part of some other term in the final rendering. Modified the script to remove both.
halindrome
added a commit
that referenced
this pull request
Jun 23, 2015
ISSUE-715: Removing unused glossary terms deletes only the term.
pkra
pushed a commit
that referenced
this pull request
May 20, 2024
Clarify relationship between html-aam and core-aam mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@halindrome. @michael-n-cooper,
The function that removes unused glossary terms is only removing the term, the DT element and not the actual definition, DD element. As a result, the DD text appears to be part of some other term.
You can see an example of this for the glossary entry for "State" here:
http://w3c.github.io/aria/aria/aria.html#dfn-state
The second paragraph of that definition is actually for "Sub-document", and the third for "Target Element".
I've found the bug, and made a simple fix. Please review this pull request, thanks.
Tracker ISSUE-715: https://www.w3.org/WAI/PF/Group/track/issues/715