Change the superclass of range from widget to structure #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support the aria-value* attributes on non-interative, and potentially static objects such as a meter. Because range now subclasses structure, we need to use multiple inheritance with the widget roles which subclass range. Those roles are: progressbar, scrollbar, slider, and spinbutton. The latter two already subclass both range and input thus no further change is needed. Progressbar and scrollbar now subclass both range and widget. Addresses github issue #892.
|
I just used github's "diff" tool to see what all changed in the actual spec content. (This is helpful because inherited states and properties get generated by scripts, rather than being hard-coded in the spec text.) I don't see any unexpected changes related to inheritance. Or for that matter related to anything else. 😄 Thus I believe this change is safe regarding taxonomy fallout. |
joanmarie
changed the title
joanmarie
added a commit
that referenced
this pull request
Jan 31, 2019
|
Merged into master and stable after making the editorial change requested at today's meeting ("a structure"->"an element") and adding the ChangeLog entry. |
mcking65
reviewed
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support the aria-value* attributes on non-interative,
and potentially static objects such as a meter.
Because range now subclasses structure, we need to use multiple inheritance
with the widget roles which subclass range. Those roles are: progressbar,
scrollbar, slider, and spinbutton. The latter two already subclass both range
and input thus no further change is needed. Progressbar and scrollbar now
subclass both range and widget.
Addresses github issue #892.
Preview | Diff