Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use element reflection for IDREF/IDREF list #920

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

alice
Copy link

@alice alice commented Mar 22, 2019

This depends on a pull request on WHATWG, which depends on implementations, which depends on something to implement, so we do have a bit of a dependency cycle here.

In any case, we are planning to send out an intent to implement this on Chrome; it should be fine to do that based on a PR, but if you have any feedback it would be much appreciated!

@BenevolentHighPriestess

Thank you

@jnurthen
Copy link
Member

Thanks @alice
We will discuss in our next chair meeting how to proceed.

@alice
Copy link
Author

alice commented Apr 11, 2019

@cookiecrook FYI

@jnurthen jnurthen merged commit e182895 into w3c:master Apr 23, 2019
@foolip
Copy link
Member

foolip commented May 8, 2019

The changes here have reached web-platform-tests in web-platform-tests/wpt#16463, and I noticed in https://wpt.fyi/results/wai-aria/idlharness.window.html?diff&filter=ADC&run_id=6543921261838336&run_id=4861101535657984 (via check) that Safari was previously passing all the tests. This is the case for Safari stable (12.1) as well:
https://wpt.fyi/results/wai-aria/idlharness.window.html?run_id=6277854882955264&run_id=5140432048619520

Was this considered when renaming? Is there a WebKit bug to follow this rename? The risk otherwise is of course that both names will rename and that web developers will have to deal with both for a long time.

@alice
Copy link
Author

alice commented May 8, 2019

Was this considered when renaming?

The fact that Safari had shipped the ARIA properties?

Note that it's less of a rename and more of a removal/add, since the type has also changed.

Is there a WebKit bug to follow this rename?

@cookiecrook to comment.

The risk otherwise is of course that both names will rename and that web developers will have to deal with both for a long time.

I doubt the old names saw a lot of use in production; is there a way to check?

@carmacleod
Copy link
Contributor

Is Safari the only one implementing so far?
@LJWatson was asking in #957

@cookiecrook
Copy link
Contributor

cookiecrook commented May 10, 2019

As I mentioned in #834, the string reflection variants should be removed from ARIA 1.2. We'll likely unship these from the WebKit implementation before the element reflection bits go in.

@foolip
Copy link
Member

foolip commented May 10, 2019

I doubt the old names saw a lot of use in production; is there a way to check?

Searching HTTP Archive using BigQuery is the method I'd use, HTTP Archive for web compat decision making has some instructions. However, depending on the expected usage this might be overkill, I'll leave it to the WebKit folks trying to remove this :) (If someone does want to run a query I can help though, just let me know.)

@cookiecrook
Copy link
Contributor

Moving this back from "Done" to "In progress" because we commented these lines for the 1.2 release.

@cookiecrook
Copy link
Contributor

I think this is all superseded now. Should be okay to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants