-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spec to Match Explainer #45
Comments
For tabs, I'd still like to see if we can do this without scope. |
Well you can do a badge without a scope (and that sets the scope to some reasonable default). The default could be the current page, which means every page needs to set the badge individually, and app badging won't work by default unless the current page is the app scope. However, I think that creates more "surprising" situations (e.g., Either way, tab badging will work automatically without having to explicitly pass a scope. |
Understood, but that's from a developers perspective.
If they are analogous to a favicon, then I don't think it would be surprising. Each page has to set its own favicon - there is no expectation that a favicon is persisted when the user navigates.
I could be sold on applying badges on a per-origin basis (without individual scopes): That could tie nicely into the origin permission model (with an implicit grant), and then a user could easily turn off badging for a whole origin if it got too annoying. |
I think the difference here is that we want to be able to apply badges to a set of pages (as in the case of an app). In the current system, if we defaulted to a 'page' scope, calling A purely per-document model doesn't solve our app badging problem. I think there was some similar discussion in this thread.
I agree this would be nice, but the app manifest spec explicitly allows multiple apps to exist on a single origin. As the spec allows this I think we should make sure that the API (whatever it ends up looking like) supports this use case. Related threads: |
The API is split into separate setClientBadge and setAppBadge (and corresponding clear methods). Also formalizes the algorithms a lot and cleans up the spec. Closes #45.
The explainer is being updated with our feedback from TAG in #39. The spec should be updated in a separate PR:
When this is done
#1 can be closed (now all badges must specify scope).
#5 can be closed (same reason)
#12 can be closed (badging of installed apps is implicit, based on scope).
#35 can be closed (same as above).
The text was updated successfully, but these errors were encountered: