Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec cleanup #34

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Spec cleanup #34

merged 4 commits into from
Jun 25, 2019

Conversation

fallaciousreasoning
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning commented Jun 20, 2019

This cleans up a few errors/warnings from ReSpec.


Preview | Diff

</p>
</section>
<section id="sotd">
<p>
This specification is currently a work in progress. Implementors should
not expose the API surface to the open web.
This is an early draft of the Badging API spec.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what to put here? It’s not in the w3c so it’s not a spec yet, but it’s not really a draft either.

(I’ve copied this from the WebShareTarget spec, mostly I just wanted it to show up as changed in the diff).

alongside the symbolic representation of the application in the user's
operating system (for example, as a small overlay on top of the
application's icon).
When the application's flag is <a>set</a>, the user agent SHOULD display
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixes #12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think #12 was about completely removing the notion of this being related to an installed app. e.g. if it worked in a tab, it could potentially be used without the app being installed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, okay. I don't know how I feel about that. The one Badge per application example gets kind of hazy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we treat this in per tab land? I think there has to be some kind of guideline about what gets badged, and I wouldn't like it to work differently based on whether or not the app is installed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. Application scope is the simplest thing to use. Let's keep it and comment on the bug.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has come up again in #35

@fallaciousreasoning fallaciousreasoning merged commit 4c99dcf into master Jun 25, 2019
@fallaciousreasoning fallaciousreasoning deleted the spec-cleanup branch June 25, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants