Clarify & simplify #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <li>The user agent MUST NOT skip or throttle processing of beacon | ||
| requests, as it may contain critical application state, events, and | ||
| analytics data.</li> | ||
| <li>The user agent MUST process the response headers, and if provided, |
There was a problem hiding this comment.
Awkward language. What we need to say is: user agent should run the request to completion, process returned set-cookies, etc, but ignore the response body if any is given.
There was a problem hiding this comment.
This should really follow from the usage of Fetch. Having all these duplicate requirements on top of those is very sketchy.
There was a problem hiding this comment.
I do think we can simplify it, assuming we can upstream some logic to Fetch..
- max payload size should be enforced by code handling the sendBeacon; the requirement should live in this spec.
- prioritization/coalescing + flush should live in Fetch.. if we agree that Request coalescing as a platform primitive? #20 is reasonable.
- Agree that response headers bits are probably redundant; is there a hook in fetch to avoid processing body, etc, if we set request type to beacon?
|
@annevk updated privacy & acknowledgement sections. ptal. |
|
Merging, we can continue to iterate in followup issues. |
This was referenced Dec 15, 2015
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://rawgit.com/w3c/beacon/clarify-simplify/index.html
An attempt at reworking the introduction, processing rules, and privacy and security sections to more accurately describe the problem sendBeacon is intended to solve, and how it should go about doing so.
In theory, this should go a long way towards addressing issues raised in: #14, #18, #13, #17.
Is it heading in the right direction?