-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set request's cors mode based on payload's object type #33
Conversation
Discussion: #32
This seems broken. We can't just allow |
|
Which locked down MIME type? |
Sorry.. I've edited my comment above to ensure it is accurate. |
With regard to ArrayBuffer and XHR... As long as the XHR is a simple request, no browser triggers a preflight for it. sendBeacon is currently designed to only create simple requests and thus can use 'no-cors' for ArrayBuffer. |
I think when we added |
But the setup you have here is even more dangerous. Whenever we add a new type to |
After a thorough scrub through Fetch with @toddreifsteck, I believe this should address #32. For motivation on this change see #32 (comment) - in particular, the comment about image beacons and chained redirects.
@toddreifsteck @annevk ptal and review. Any other edge cases we need to cover here?