Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links #96

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Update links #96

merged 4 commits into from
Dec 22, 2023

Conversation

xfq
Copy link
Member

@xfq xfq commented Apr 28, 2023

This PR:

  • uses relative links for internal links
  • uses /International links for articles
  • uses /TR links for string-meta and the language enablement index

Preview | Diff

xfq added 2 commits April 28, 2023 13:37
- Use relative links for internal links
- Use /International links for articles
- Use /TR links for string-meta and the language enablement index
@xfq xfq requested review from aphillips and r12a April 28, 2023 05:39
@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for bp-i18n-specdev ready!

Name Link
🔨 Latest commit a71c946
🔍 Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/65861ff12298f500084495bd
😎 Deploy Preview https://deploy-preview-96--bp-i18n-specdev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

index.html Outdated
@@ -198,7 +198,7 @@ <h3>Language basics</h3>


<div class="req" id="lang_basics_meta">
<p class="advisement">Consider whether it is useful to express the <a href="https://w3c.github.io/bp-i18n-specdev/#sec_lang_meta">intended linguistic audience</a> of a resource, in addition to specifying the language used for <a href="https://w3c.github.io/bp-i18n-specdev/#sec_text_processing_lang">text processing</a>.</p>
<p class="advisement">Consider whether it is useful to express the <a href="#sec_lang_meta">intended linguistic audience</a> of a resource, in addition to specifying the language used for <a href="#sec_text_processing_lang">text processing</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the ReSpec markup to create the links. When we generate the TR version, the resulting markup would end up with complete document links instead of relative links, which is useful when people copy the content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the problem is that I'm not sure how to add link text if I use the [[[#some-id]]] syntax.

ReSpec will automatically generate the link text using the section name, but sometimes we do not want to use the section name as the link text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that intended linguistic audience wants to be a term (we have text processing language in the glossary: this has historically been its counterpoint). I'm not sure we want to put it into our formal glossary, but we might want to define it locally to specdev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I just defined it in specdev.

@xfq xfq requested a review from aphillips December 21, 2023 05:49
Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the conflict. This looks good otherwise.

@aphillips aphillips merged commit ab5f4d0 into gh-pages Dec 22, 2023
4 checks passed
@aphillips aphillips deleted the xfq/update-links-20230428 branch December 22, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants