Skip to content

Editorial: firing event not done correctly (closes #401) #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2017
Merged

Editorial: firing event not done correctly (closes #401) #433

merged 1 commit into from
Feb 27, 2017

Conversation

marcoscaceres
Copy link
Member

No description provided.

domenic
domenic requested changes Feb 23, 2017
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the original issue was filed, the "queue a task" was moved to the caller, so it should not be added here. Otherwise LGTM, feel free to merge after addressing that.

@marcoscaceres
Copy link
Member Author

Removed redundant "queue a task".

@marcoscaceres marcoscaceres merged commit 03b7c71 into gh-pages Feb 27, 2017
@marcoscaceres marcoscaceres deleted the events branch February 27, 2017 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoscaceres @domenic