Proofread #183
Merged
Proofread #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfq
reviewed
Jul 9, 2018
xfq
reviewed
Jul 9, 2018
|
@xfq 改好咯 |
xfq
approved these changes
Jul 22, 2018
r12a
reviewed
Jul 23, 2018
r12a
reviewed
Jul 23, 2018
r12a
reviewed
Jul 23, 2018
| <p data-lang="en">Interpuncts <span class="uname">U+00B7 MIDDLE DOT</span> [·], also known as interpoints, middots or centered dots, are punctuation marks consisting of a vertically-centered dot, and is used to separate the first name and family name in names translated from foreign languages or minorities. They are also used with book title marks to separate chapters, articles and volumes in publications.</p> | ||
| <p data-lang="zh-hans">间隔号为<span class="uname" translate="no">U+00B7 MIDDLE DOT</span> [·]。用于双书名号（书名号乙式）分隔篇、章、卷，以及外国人名中文译名、少数民族音译名，分隔姓名使用。</p> | ||
| <p data-lang="zh-hant">間隔號為<span class="uname" translate="no">U+00B7 MIDDLE DOT</span> [·]。用於書名號乙式（雙書名號）分隔篇、章、卷，以及外國人名中文譯名、少數民族音譯名，分隔姓名使用。</p> | ||
| <p data-lang="en">Interpuncts apply to Chinese only. When a translated foreign name contains a Latin character, a western period should be used rather than a interpunct. For example, <span lang="zh-hant">比尔·盖茨</span> but <span lang="zh-hant">B. 盖茨</span>.</p> |
There was a problem hiding this comment.
These examples don't look right, because no chinese font is applied to middle dot for the hant samples. The chinese characters are using a fallback font. I'll raise a new issue about this.
r12a
reviewed
Jul 23, 2018
bobbytung
approved these changes
Jan 16, 2019
|
It looks like many of the review comments were not acted upon or replied to before the merge attempt. Were they overlooked, or was it intentional? |
@r12a Sorry, I’ll try to reply the review comments and fix them next week. There would not be a merge before the fixes. |
r12a
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個PR盡可能統一了繁簡的用語並去除簡體段落的checkme標示。原本想全部搞定再一起上，但礙於時間問題，且一直拖著必然衝突會愈來愈多導致合并的困難，所以先上了已修改的部分。
Preview | Diff