Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links that should point back to ARIA are now all broken in github.io editors draft #181

Closed
spectranaut opened this issue Jun 24, 2023 · 5 comments
Assignees

Comments

@spectranaut
Copy link
Contributor

spectranaut commented Jun 24, 2023

In the published editors draft: https://w3c.github.io/core-aam/

Any role or attribute link which used to go back to the ARIA spec now just adds a URL fragment to the role or attribute.

For example:

  1. Click "aria-live" in this section: https://w3c.github.io/core-aam/#mapping_nodirect
  2. Click "alert" in https://w3c.github.io/core-aam/#role-map-alert
@spectranaut
Copy link
Contributor Author

spectranaut commented Jun 24, 2023

Hey Michael -- I'm not sure why, but it looks like this recent change from you caused this breakage: ed79fdf

If I checkout out the commit before, the bug isn't there, so I tried your change to index.js line by line -- and its updating:

    specStatus:           "ED",

to

    specStatus:           "CRD",

That causes the links to break?? I'm pretty confused, I wonder if you understand why?

@jnurthen
Copy link
Member

The document header needs a CRD entry for the ARIA specs so it knows where to point in that version.

    ariaSpecURLs: {
      "ED": "https://w3c.github.io/aria/",
      "WD" : "https://www.w3.org/TR/wai-aria/",
      "CR" : "https://www.w3.org/TR/wai-aria/",
      "CRD": "https://www.w3.org/TR/wai-aria/",
      "PR" : "https://www.w3.org/TR/wai-aria/",
      "REC": "https://www.w3.org/TR/wai-aria/",
    },

The other entries also need updating. I think the above are the correct values.
The same needs to happen for the ACCNAME URLs too.

@spectranaut
Copy link
Contributor Author

Shouldn't the main branch stay "ED", and a branch be add for CRD?

@jnurthen
Copy link
Member

Shouldn't the main branch stay "ED", and a branch be add for CRD?

Why? Isn’t the whole point of evergreen that we push PRs to the real spec once they are merged?

@daniel-montalvo
Copy link
Contributor

I can update those based on what we decide. I would say that it makes sense to have the main branch be the CRD branch as @jnurthen suggests.

daniel-montalvo added a commit that referenced this issue Jun 26, 2023
github-actions bot added a commit that referenced this issue Jun 26, 2023
SHA: dbf9bc2
Reason: push, by daniel-montalvo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants