Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-5] Spec wording on which color keywords are valid #10191

Closed
tiaanl opened this issue Apr 10, 2024 · 3 comments
Closed

[css-color-5] Spec wording on which color keywords are valid #10191

tiaanl opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification

Comments

@tiaanl
Copy link
Contributor

tiaanl commented Apr 10, 2024

Referring to this line:

referring to one of the channels of the [=origin color=].

It reads: ...or be specified as a channel keyword referring to one of the channels of the origin color.

At this point there is no mention of the origin color being converted to the color being specified yet, so the assumption might be that specifying rgb(from hsl(0, 100% 50%) h s l) the h, s and l keywords should work.

@svgeesus
Copy link
Contributor

Fair enough.

The spec does go on to say

If the originally specified color space for the origin color used a different color function, it’s first converted into the chosen color function, so it has meaningful values for the channels.

But perhaps that does need to be said earlier.

@svgeesus svgeesus self-assigned this Apr 10, 2024
@svgeesus svgeesus added Needs Edits css-color-5 Color modification labels Apr 10, 2024
svgeesus added a commit that referenced this issue Apr 12, 2024
…tactic details. Clarify which color space the channel keywords relate to, #10191
@svgeesus
Copy link
Contributor

@tiaanl Is the spec clearer now?

@tiaanl
Copy link
Contributor Author

tiaanl commented Apr 13, 2024

@svgeesus Much clearer, thanks

@tiaanl tiaanl closed this as completed Apr 13, 2024
@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Needs Edits labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification
Projects
None yet
Development

No branches or pull requests

2 participants