Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Clarify sentence construction in max-content flex fraction step #1803

Closed
astearns opened this issue Sep 11, 2017 · 3 comments
Closed
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work Tracked in DoC

Comments

@astearns
Copy link
Member

The first step in https://drafts.csswg.org/css-flexbox/#intrinsic-main-sizes has a fairly complex second sentence. I had to read it twice to note that the parentheticals referred to the same result in the first clause. Scanning quickly I assigned the parentheticals to their closest sentence part. I think my problem is that the parenthetical came after the preposition.

In other words, in this construction "if the result is not zero, divide it by {(some parenthetical) its foo}" I'm scanning {} as a prepositional phrase that's the object of the verb. It took me a bit to notice the word 'result' and fix my confusion.

I think it would be clearer to say "if the result is not zero, divide a positive result by … or a negative result by …"

@fantasai
Copy link
Collaborator

We don't really need to call out zero here, do we. Fixed with that simplification, let me know if it works @astearns ? :)

@astearns
Copy link
Member Author

Could you add "divide" to the second path?

@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
fantasai added a commit that referenced this issue Mar 29, 2018
…max-content flex fraction. Re-applies fix for #1803, which was lost during revert of #1735.
@fantasai
Copy link
Collaborator

Done.

@fantasai fantasai added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Mar 29, 2018
fergald pushed a commit to fergald/csswg-drafts that referenced this issue May 7, 2018
…max-content flex fraction. Re-applies fix for w3c#1803, which was lost during revert of w3c#1735.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work Tracked in DoC
Projects
None yet
Development

No branches or pull requests

2 participants