Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move overscroll-behavior spec from WICG to csswg-drafts #2179

Closed
majido opened this issue Jan 10, 2018 · 25 comments
Closed

Move overscroll-behavior spec from WICG to csswg-drafts #2179

majido opened this issue Jan 10, 2018 · 25 comments

Comments

@majido
Copy link
Contributor

majido commented Jan 10, 2018

As per earlier csswg decision overscroll-behavior specification has been incubating in WICG for a while. The property has now shipped in Chrome M63 and it is planned to be shipped in Firefox M59. The proposal also has general approval of TAG.

I propose to move the specification to csswg-drafts so that it can be tracked here and moves forward
in the standardization process.

@majido
Copy link
Contributor Author

majido commented Jan 10, 2018

@bgirard @theres-waldo

@frivoal
Copy link
Collaborator

frivoal commented Jan 11, 2018

If it's already shipping (or almost) in two browsers, I'd actually say that we're quite late in taking it out of incubation.

The current editor, @bgirard, isn't a member of the CSSWG. Does he plan to join? Do we need to find/appoint a new editor?

@majido
Copy link
Contributor Author

majido commented Jan 11, 2018 via email

@frivoal
Copy link
Collaborator

frivoal commented Jan 11, 2018

I was no so much concerned about IP rights, which is what matters for whether or not Facebook is a members. Someone will have to care about that, but not me :)

No, I was just thinking of actually editing the document. It seems much simpler to have the editor going forward either be the same person that has been doing it until now, or at least someone who's been involved since the start. First it's just fair, there's not reason to take the work away from it's authors, and also we'll save a lot of time if the person handling it knows why things are the way they are.

So yes, if @bgirard can join the group, that'd be great, and if not, if you could, that'd great too.

But anyway, editorship is the chairs' call.

@svgeesus
Copy link
Contributor

@bgirard can answer that but I thought Facebook is a member organization.

Facebook is a member of W3C, but they have not joined the CSS Working Group. Each organization that is a W3C member has a designated contact point (AC member, in W3C jargon) so I sent a mail just now to the Facebook contact, inviting Facebook to join the CSS WG.

@bgirard
Copy link
Contributor

bgirard commented Jan 11, 2018

That's correct. I'll follow-up as well with Facebook's W3C representative. Facebook had already began discussing joining so I hope finalizing that will be straight forward.

I'm happy to continue to edit the spec to the best of my ability, or to step aside if someone better suited wants to take over. As long as we have a good quality spec in sync with the current implementations and vise versa.

@majido
Copy link
Contributor Author

majido commented Jan 11, 2018

Great. It seems that we should hopefully be able to have @bgirard continue as the editor if chair does not object.

Setting that question aside, I see now that this is scheduled to be on the agenda. So I believe we just wait for WG to approve.

I just wanted to add a few minor notes/questions on the migration process:

  • The spec in already in bikeshed so it should not need a lot of formatting change. But it may be valuable to have a csswg expert to do a review to ensure we are doing the right thing e.g., linking to the appropriate concepts etc. Probably best to happen after migration.
  • There are two small open issues. It will be nice if we close them before migration but otherwise we need to migrate those as well.
  • I know of at least one specification, scroll-anchoring, that has gone from wicg->csswg-draft. So WICG folks may already have a well established process. Here is more details.
  • Is there a way to keep commit history remain intact? It will be nice but I am not sure how given that this is not just a matter or moving the repo across organizations. This is not critical though since the spec is not very old.

@birtles
Copy link
Contributor

birtles commented Jan 11, 2018

  • Is there a way to keep commit history remain intact? It will be nice but I am not sure how given that this is not just a matter or moving the repo across organizations. This is not critical though since the spec is not very old.

Yes, there is. I moved web-animations to csswg-drafts recently and after I did that @SimonSapin told me how to do it:

"What I’ve done before in other repositories is make a commit that moves everything into a sub-directory, and then merge the two previously-unrelated branches. That way history is preserved without rewriting commit hashes."

@gsnedders also has experience with this.

@tantek
Copy link
Member

tantek commented Jan 14, 2018

+1 let's move this spec to CSSWG please. I'd prefer to see editorship continuity if at all possible. Thanks!

@css-meeting-bot
Copy link
Member

The Working Group just discussed Move overscroll-behavior spec from WICG to csswg-drafts, and agreed to the following resolutions:

  • RESOLVED: bring the overscroll-behavior spec to CSSWG drafts?
The full IRC log of that discussion <dael> Topic: Move overscroll-behavior spec from WICG to csswg-drafts
<dael> github: https://github.com//issues/2179
<dael> Rossen_: Since FLorian has sent his regrets, is tantek or Chris able to represent?
<dael> Chris: I'm here.
<dael> Rossen_: Can you present this since you're active on the thread?
<dael> Chris: Okay. Ths is a proposal for the overscroll-behavior. It's been incubated. There's 2 impl, 1 shipped one about to be. A bit late to move it but it should be. I wrote to the Facebook AC rep asking them to join. THis seems a reasonable spec and reasonable to pick up. tantek was also in favor.
<dael> smfr: I'm in favor for Apple.
<dael> Rossen_: Okay.
<dael> Rossen_: Any objections to bringing the overscroll-behavior spec to CSSWG drafts?
<dael> RESOLVED: bring the overscroll-behavior spec to CSSWG drafts?
<dael> s/drafts?/drafts
<dael> Rossen_: Chris will this transfer as an ED?
<dael> Chris: Yes and then we have to do the FPWD thing. I think scroll-anchoring was the first we moved.
<dael> Rossen_: So what we did there we replicate. We bring as ED and then do first publich
<dael> Chris: Exactly.

@fantasai
Copy link
Collaborator

Agenda+ because it seems that nobody followed up on this, and somebody needs to.

@astearns
Copy link
Member

@bgirard any update on having Facebook join the working group? We tried to contact your AC rep but did not get a response.

@bgirard
Copy link
Contributor

bgirard commented Apr 2, 2018

I chatted about this with our AC rep and a few other folks and I'm not sure if I can commit enough time to join the CSS working group and I haven't been able to find someone else to take it on right now 😕.

That being said, I'm hoping that as we on board more people to our team we will be able to find someone to participate in the group in the future.

@svgeesus
Copy link
Contributor

svgeesus commented Apr 2, 2018

@bgirard the amount of time you commit is largely up to you. It is fine to have only one spec you are interested in, for example.

Would it be possible to have you join now, and then transition that role to someone else as your time grows in the future? That would help us keep the momentum going on this spec.

@majido
Copy link
Contributor Author

majido commented Apr 10, 2018

@bgirard I had a chat with @astearns and a few others at CSSWG F2F yesterday. I am planning to join the WG as a member mainly to continue animation worklet specification as it moves to the working group. I had concerns around how much time I need to spend particularly for the weekly teleconferences.

He confirmed that the expectation for editors of specs with limited scope is to simply attend such meetings only when there is an agenda item related to the specification. Agenda is posted in advance of the meeting which helps decide if attendance is needed. Most of the issues on specs don't need to be discussed on teleconference and will be resolved via github.

This helped convince me that there is limited overhead in my case. Just wanted to share this in case it helps with your decision one way or another.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Move overscroll-behavior spec from WICG to csswg-drafts.

The full IRC log of that discussion <dael> Topic: Move overscroll-behavior spec from WICG to csswg-drafts
<dael> github: https://github.com//issues/2179
<tantek> In practice we have 3 2.1 editors in the room, since fantasai has been editing 2.1 for many years in practice, and gsnedders voluntered to edit 2.1 also
<gsnedders> And we have a resolution adding me as an editor from last year.
<tantek> (those two statements should be outside of this issue)
<dael> astearns: We resolved to do that. And we're still waiting on Facebook to join. majidvp added a comment saying it'll be okay, please do this thing. Hopefully they'll find time to continue the spec.
<dael> astearns: You're not interested in co-editing majidvp ?
<dael> majidvp: I mentioned in the discussion I'm happy to be the fallback, but I prefer the original editor.
<dael> astearns: Hopefully soon we can get Facebook in and you two can continue.
<dael> Rossen: majidvp thank you.
<dael> Rossen: Do we have a timeline on when this will come from WICG?
<dael> astearns: TBD because we need an editor.
<dael> Rossen: If we added majidvp today can we move the spec?
<dael> astearns: It's overcommitting majidvp I think.
<dael> majidvp: The right thing is give the current editor some more time.
<dael> astearns: We'll wait on a response.

@majido
Copy link
Contributor Author

majido commented Jul 31, 2018

@bgirard has there been any change in your plans regarding joining the CSSWG?

Unless we have new updates, I think we should follow with our plan as discussed in F2F and noted above and move the repo to CSSWG.

@majido
Copy link
Contributor Author

majido commented Jul 31, 2018

I will handle the move logistics. Here is my plan so far, please make suggestions and corrections as you see fit.

Merging repos without losing history

I did a test run based on @birtles suggested path and the history remains intact.

Basically, it is a merging two unrelated git histories but git is happy to do so none the less and things seems to be working as expected.

Here is the series of command I used:

$ cd csswg-drafts
$ git remote add wicg git@github.com:WICG/scroll-boundary-behavior.git
$ git fetch wicg
$ git checkout -b wicg wicg/master
$ mkdir css-overscroll-behavior
$ mv * css-overscroll-behavior/
$ git add .
$ git commit -m "Move to sub-directory in preparation to move the repository"
$ git checkout master 
$ git merge wicg
$ git merge --allow-unrelated-histories wicg

I pushed the result to my GH fork and all the history is intact. See here for example.

I suspect then it is just a matter of sending a PR for the above repr and making sure the PR is merged without squashing and rebasing.

Migrating open issues

There are three open issues. I will manually re-create these in csswg-drafts with proper labels etc.

Post move

  1. Update index.bs fix
    • shortname to css-overscroll-behavior
    • URL to https://drafts.csswg.org/css-overscroll-behavior/
    • Status to ED
    • Repository to https://github.com/w3c/csswg-drafts/tree/master/css-overscroll-behavior css-overscroll-behavior
    • Add myself as an editor
  2. Remove LICENSE.md, CONTRIBUTING.md, security-privacy-questionnaire.md

The spec is already in Bikeshed and builds without any warnings so hopefully that means it will not create any issues for csswg-draft tools.
So my plan is to merge the repo as is (with the exception of moving to subdirectory) and make necessary changes to deal with any issues after the merge. Let me know if there is anything I am missing or should try to fix before merging the repo.

majido added a commit to majido/csswg-drafts that referenced this issue Sep 25, 2018
Brings overscroll-behavior repo to csswg-drafts repo without losing
history. This is achieved using `git merge --allow-unrelated-histories`
which allows a merge commit to contain two commits that don't share any
ancestor.

Fix issue w3c#2179
tabatkins added a commit that referenced this issue Sep 28, 2018
[css-overscroll-behavior] Merge overscroll-behavior specification #2179
@ewilligers
Copy link
Contributor

https://drafts.csswg.org/css-overscroll-behavior/ currently gives a list of files.
https://drafts.csswg.org/css-overscroll-behavior/index.html currently gives the spec.

For most specs, / gives the spec and /index.html gives 404 Not Found.

@frivoal
Copy link
Collaborator

frivoal commented Oct 10, 2018

@ewilligers, fixed e6103a5

frivoal added a commit that referenced this issue Oct 10, 2018
frivoal added a commit that referenced this issue Oct 10, 2018
@frivoal
Copy link
Collaborator

frivoal commented Oct 10, 2018

I think we just need @majido to add himself as an editor, and then we can close this.

@xfq
Copy link
Member

xfq commented Oct 16, 2018

In drafts.csswg.org, css-overscroll-behavior is currently listed in "Other Documents", instead of "Specification". We should fix this too.

@xfq
Copy link
Member

xfq commented Oct 16, 2018

And we probably want to publish a FPWD too.

@majido
Copy link
Contributor Author

majido commented Oct 18, 2018

@frivoal Sent a PR to add myself as an editor.
@xfq I agree. I just added an agenda item for TPAC F2F to discuss this spec and move it to FPWD.

frivoal added a commit that referenced this issue Oct 18, 2018
[css-overscroll-behavior] Add majidvp@google.com as overscroll-behavior editor #2179
@frivoal
Copy link
Collaborator

frivoal commented Oct 18, 2018

@majido Merged, but you don't need pull requests for changes like this. You're an editor, you can commit directly. Pull requests are useful for proposing changes to the WG prior to getting a resolution, or for asking someone to check after implementing a subtle resolution, but generally fell free to just commit directly to the spec. If you're a bit unsure about the balance of power between the Editor and the WG in the CSSWG, here is a good reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests