Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-3] word-wrap/overflow-wrap: break-word should affect min-content #2682

Closed
fantasai opened this issue May 19, 2018 · 21 comments · Fixed by #2738
Closed

[css-text-3] word-wrap/overflow-wrap: break-word should affect min-content #2682

fantasai opened this issue May 19, 2018 · 21 comments · Fixed by #2738
Assignees
Labels

Comments

@fantasai
Copy link
Collaborator

fantasai commented May 19, 2018

See #2270 (comment) and #2390 //cc @Dan503

Right now word-wrap/overflow-wrap: break-word allows long words to wrap if they are too long to fit in the container, but in an auto-sized container, they will still force the container to grow. This is frustrating to authors. Issue 2390 is about adding a break-word value to word-break to address this feature (because WebKit/Blink happen to have implemented such a thing), but then we end up with two extremely similar-looking property-value pairs that do almost exactly the same thing except for this side-effect of how they influence the min-content size.

The number of line-breaking controls in CSS is already crazy confusing; we really don't need to have the similarity between word-wrap: break-word and word-break: break-word compounding the situation. Also I suspect that making the already-existing word-wrap: break-word influence min-content sizes is a reasonable thing to do regardless: it can't do its job of allowing breaking if the container is forced to fit the thing that it's trying to break anyway.

So the proposal is to make the existing word-wrap/overflow-wrap property affect intrinsic sizing and, hopefully, also close #2390 as no change.

@frivoal
Copy link
Collaborator

frivoal commented May 19, 2018

If we can do that, I am totally in support. But can we? Assessing web compat on this seems tricky.

I am reasonably convinced that anyone who intentionally combines overflow-wrap:break-word and shrinkwrapping (or some other sizing that depends on min-content) would be positively affected by this change, but it's the non intentional uses that I'm worried about.

@anjia
Copy link

anjia commented May 22, 2018

So the proposal is to make the existing word-wrap/overflow-wrap property affect intrinsic sizing

Yeah, I agree with it because that's reasonable, and the behavior is logical in my opinion.

  1. word-wrap/overflow-wrap affects the display effect of the text,
  2. then the text affects the intrinsic sizing

As for the point ... but it's the non intentional uses that I'm worried about @frivoal mentioned, it's indeed a problem. But I think may be ... developers could forgive this change as they indeed wrote the word-wrap/overflow-wrap property which can affect the text ?

@frivoal
Copy link
Collaborator

frivoal commented May 23, 2018

@anjia authors who think about it would probably be fine. Existing pages which are already deployed, aren't maintained, and apply overflow-wrap:break-spaces to intrinsically sized things for no good reason might suddenly look weird, and users would be unhappy. I don't think that particular type of breakage is likely to be that common, but what we need to worry about is its effects on users, rather than on the mood of developers.

I think that most likely we'll be fine, and if so this is a great way out of the current mess.

@anjia
Copy link

anjia commented May 23, 2018

but what we need to worry about is its effects on users, rather than on the mood of developers.

@frivoal yeah, you're right. This thought refreshes my responsibility as a csswg member. Thanks very much

@css-meeting-bot
Copy link
Member

The Working Group just discussed word-wrap/overflow-wrap: break-word should affect min-content, and agreed to the following:

  • RESOLVED: Accept the proposal in Issue #2682
The full IRC log of that discussion <dael> Topic: word-wrap/overflow-wrap: break-word should affect min-content
<dael> github: https://github.com//issues/2682
<dael> fantasai: Issue is that...there's a number of cases where authors are fustrated with elements being bigger then they ought to be. Some are because they put overflow:scroll. Other set are related to I thought I told the text to be able to wrap if it needs to, why is element so big
<dael> fantasai: That's the word-wrap/overflow-wrap:break-word which doesn't effect min-content.
<dael> fantasai: There was discussion about word-break:break-word from webkit that does effect intrinisic size. We decided we wouldn't add that unless FF or Edge said they needed
<florian> q+
<dael> fantasai: proposal is to solve several things. Give the authors the behavior that they're expecting so content can shrink down in the way they expect since right now if you're auto sizing the width is too big to break. It also means we can address reasons for the other syntax existing without adding the other syntax.
<florian> q-
<dael> fantasai: Having the syntactic mess is an awful situation to get in.
<dael> florian: Cannonical example is when there is a piece of text in a table cell with a long word and the put the overflow-wrap:break-word and the word stays long.
<dael> fantasai: It's prob getting more frustrating because effects min-content in grid or flexbox. You put a URL in and say you can break, but it pushes out 1fr column for no good reason. It's not just in table cells. Flexbox and grid are relying on the min-content size.
<dael> florian: Overall if we can do this it's a good idea. Can we or do we break compat with negative effects? I'm not too pessimistic but want to make sure
<dael> fantasai: It's a concern in general, but I think there's enough cases where changing behavior gets authors to where they want more then it breaks. Cases that will break is when you set overflow-wrap to a place where it allows breaking but then you're not expecting a break.
<dael> fantasai: Most layouts aren't dependent on longest word. They asked for wrapping. I think more likely to fix then to break.
<dael> ??: Seems fair
<dael> Rossen: To be clear blink and webkit have this?
<dael> fantasai: Under a different syntax. We've pushed back on adding that syntax. Only difference between is how the effect intrinisic sizing. It's small but super confusing for authors. Even if they weren't syntactically similar it's still confusing to think in terms of intrinsic size
<dael> Rossen: word-wrap:break-word you take all breaking content?
<dael> fantasai: Just in min size
<dael> florian: word-break controls other things as well, so with word-break:break-word you can't do that. With this appoarch you could.
<dael> Rossen: Just wanted to clarify expectations
<dael> Rossen: Other opinions? Sounds reasonable way forward. Have to see what interop looks like
<dael> Rossen: Or compat risk rather
<dael> florian: Yeah
<dael> fantasai: Yeah
<dael> fantasai: Authors will be happy if we fix this. This is a major source of frustration with grid and flexbox. Sometimes allowing breaks...things get too big
<dael> Rossen: I'm with you.
<tantek> +1 [CSS is awe]some
<dael> Rossen: I'm mostly worried about older content in tables and whatnot out in the wild. All the sudden we introduce an adverse effect. But I'll let blink and webkit engineers spearhead since they have this behavior.
<dael> Rossen: Objections?
<dael> RESOLVED: Accept the proposal in Issue #2682

@frivoal
Copy link
Collaborator

frivoal commented Jun 6, 2018

I've made PRs for the spec and wpt:

@CShepartd
Copy link

CShepartd commented Jun 26, 2018

@fantasai
It will pass test? https://jsfiddle.net/ofgd83um/53/

@fantasai
Copy link
Collaborator Author

@CShepartd That test doesn't have a pass condition, but what should happen is that the Box 6 will have the same width as Box 2. (The word-break: break-word declaration for 4 would be invalid, so it will render the same as 1.)

@fantasai
Copy link
Collaborator Author

(Note that overflow-wrap and word-wrap are the same property--they enable breaking when it's not “normal” if the text won't fit otherwise--so either one will work. But word-break won't because that's a different property.)

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 9, 2018
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 9, 2018
Per w3c/csswg-drafts#2682

Differential Revision: https://phabricator.services.mozilla.com/D11328

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1505786
gecko-commit: 9a315872bd6d11ac42871b083961a00fa53ee753
gecko-integration-branch: autoland
gecko-reviewers: xidorn, jfkthame
emilio added a commit to emilio/servo that referenced this issue Nov 10, 2018
@CShepartd
Copy link

CShepartd commented Nov 14, 2018

overflow-wrap: anywhere solving very well problem of missing word-break: break-word https://jsfiddle.net/ofgd83um/80/

@frivoal frivoal added the Tested Memory aid - issue has WPT tests label Apr 25, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
Per w3c/csswg-drafts#2682

Differential Revision: https://phabricator.services.mozilla.com/D11328

UltraBlame original commit: 9a315872bd6d11ac42871b083961a00fa53ee753
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
Per w3c/csswg-drafts#2682

Differential Revision: https://phabricator.services.mozilla.com/D11328

UltraBlame original commit: 9a315872bd6d11ac42871b083961a00fa53ee753
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
Per w3c/csswg-drafts#2682

Differential Revision: https://phabricator.services.mozilla.com/D11328

UltraBlame original commit: 9a315872bd6d11ac42871b083961a00fa53ee753
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 8, 2019
There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 8, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 9, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 30, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 30, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 1, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

[1] w3c/csswg-drafts#2682

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 4, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}
Hexcles pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2019
This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 29, 2019
… anywhere' feature, a=testonly

Automatic update from web-platform-tests
[css-text] Implement the 'overflow-wrap: anywhere' feature

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}

--
Fix Ahem

--

wpt-commits: fd6d0cf9a5695ab232b125089ffc6bf42756d053, ad37572b36809af1f914f1b90cb15ae258ce9581
wpt-pr: 19570
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Nov 29, 2019
… anywhere' feature, a=testonly

Automatic update from web-platform-tests
[css-text] Implement the 'overflow-wrap: anywhere' feature

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}

--
Fix Ahem

--

wpt-commits: fd6d0cf9a5695ab232b125089ffc6bf42756d053, ad37572b36809af1f914f1b90cb15ae258ce9581
wpt-pr: 19570
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2019
… anywhere' feature, a=testonly

Automatic update from web-platform-tests
[css-text] Implement the 'overflow-wrap: anywhere' feature

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandezigalia.com>
Reviewed-by: Koji Ishii <kojiichromium.org>
Cr-Commit-Position: refs/heads/master{#712867}

--
Fix Ahem

--

wpt-commits: fd6d0cf9a5695ab232b125089ffc6bf42756d053, ad37572b36809af1f914f1b90cb15ae258ce9581
wpt-pr: 19570

UltraBlame original commit: 52c6db0b33d632d737fafbff81db3752430f3085
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2019
… anywhere' feature, a=testonly

Automatic update from web-platform-tests
[css-text] Implement the 'overflow-wrap: anywhere' feature

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandezigalia.com>
Reviewed-by: Koji Ishii <kojiichromium.org>
Cr-Commit-Position: refs/heads/master{#712867}

--
Fix Ahem

--

wpt-commits: fd6d0cf9a5695ab232b125089ffc6bf42756d053, ad37572b36809af1f914f1b90cb15ae258ce9581
wpt-pr: 19570

UltraBlame original commit: 52c6db0b33d632d737fafbff81db3752430f3085
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2019
… anywhere' feature, a=testonly

Automatic update from web-platform-tests
[css-text] Implement the 'overflow-wrap: anywhere' feature

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] w3c/csswg-drafts#2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandezigalia.com>
Reviewed-by: Koji Ishii <kojiichromium.org>
Cr-Commit-Position: refs/heads/master{#712867}

--
Fix Ahem

--

wpt-commits: fd6d0cf9a5695ab232b125089ffc6bf42756d053, ad37572b36809af1f914f1b90cb15ae258ce9581
wpt-pr: 19570

UltraBlame original commit: 52c6db0b33d632d737fafbff81db3752430f3085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants