Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-1] Define computed value of grid-template-rows/columns #3154

Closed
fantasai opened this issue Sep 26, 2018 · 4 comments
Closed

[css-grid-1] Define computed value of grid-template-rows/columns #3154

fantasai opened this issue Sep 26, 2018 · 4 comments

Comments

@fantasai
Copy link
Collaborator

The computed value of grid-template-rows/columns is somewhat handwavy. It's not exposed by getComputedStyle() since that returns the resolved value, but we should be more precise here so that it's clear e.g. minmax(auto, auto) [] 4px can interpolate with auto 10px.

@fantasai
Copy link
Collaborator Author

fantasai commented Oct 8, 2018

So I checked in changes to clarify this, currently the spec says

the keyword none or a list, alternating each item as either a (potentially empty) list of identifiers or a minmax() or repeat() notation, representing each <track-size> as a minmax() notation and each <length-percentage> computed

It needs some follow-up to clarify that the computation nests into repeat(), and that there is a name list at both the start and end of each track listing (at the top level and within each repeat).

Gonna file a separate issue on interpolation.

@tabatkins
Copy link
Member

Agenda+ to confirm that our edits are good.

@fantasai
Copy link
Collaborator Author

fantasai commented Oct 8, 2018

Filed #3201 on interpolation.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Define computed value of grid-template-rows/columns, and agreed to the following:

  • RESOLVED: Accept this edit: https://github.com/w3c/csswg-drafts/commit/63a1d65afa5997a56b210c1cbddccdb2603ecec9
The full IRC log of that discussion <dael> Topic: Define computed value of grid-template-rows/columns
<dael> github: https://github.com//issues/3154#issuecomment-428002686
<dael> fantasai: As part of fix computed values I noticed this. Wanted to cross check witht he group this seemed reasonable
<dael> fantasai: Current ED says [reads]
<astearns> https://github.com/w3c/csswg-drafts/commit/63a1d65afa5997a56b210c1cbddccdb2603ecec9
<dael> fantasai: What this means is no distinction in computed value of 50px and minmax(50px)50px. functionally same so shouldn't be a distinction
<fantasai> minmax(50px,50px)
<dael> astearns: Any idea about what's impl?
<dael> fantasai: Didn't check
<dael> fantasai: It's hard to check because gCS is the used value for these prop so can't retrive computed value
<dael> fantasai: Main check would be animating between. Not sure animation is well supported
<dael> fantasai: This would clarify
<dael> rego: I think animations aren't working on any mpl yet so hard to check
<dael> astearns: I like the clarification and seems reasonable to me. Haven't thought through implications for animations
<dael> fantasai: What this does is makes it as likely as possible to animate between 2 values so that functionally same values compute to each other. Everything matchs so values that mean the same are represented same.
<dael> fantasai: Additional magic we might want for animating, but that's issue #3201. Computed value that's best we can do to make animation as easy as can be
<dael> astearns: Other comments?
<dael> astearns: Concerns?
<dael> emilio: Can test be written? All this is tricky and to get interop tests would be best
<dael> fantasai: Tests would be for animation and this is not being animated as far as I know. Be we can write tests
<dael> astearns: When someone impl animations for these properties tests will need to be written
<emilio> yeah, fair enough
<dael> astearns: Concern or objection on taking this edit: https://github.com/w3c/csswg-drafts/commit/63a1d65afa5997a56b210c1cbddccdb2603ecec9 ?
<dael> RESOLVED: Accept this edit: https://github.com/w3c/csswg-drafts/commit/63a1d65afa5997a56b210c1cbddccdb2603ecec9
<fantasai> https://github.com//issues/3201
<dael> fantasai: Issue #3201 is looking for impl feedback

@fantasai fantasai added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label Dec 10, 2018
@fantasai fantasai added this to the css-grid-1 CR 2017-12-14+ milestone Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants