Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-scroll-snap] scroll-padding-block/inline and auto #3189

Closed
ewilligers opened this issue Oct 2, 2018 · 6 comments
Closed

[css-scroll-snap] scroll-padding-block/inline and auto #3189

ewilligers opened this issue Oct 2, 2018 · 6 comments
Labels
Closed Accepted as Obvious Bugfix css-scroll-snap-1 Current Work

Comments

@ewilligers
Copy link
Contributor

The following properties have auto as their initial value, but their grammars only accept <length> values:

  • scroll-padding-block
  • scroll-padding-block-end
  • scroll-padding-block-start
  • scroll-padding-inline
  • scroll-padding-inline-end
  • scroll-padding-inline-start

https://drafts.csswg.org/css-scroll-snap-1/#padding-longhands-logical
@ewilligers ewilligers added the css-scroll-snap-1 Current Work label Oct 2, 2018
fantasai added a commit that referenced this issue Oct 3, 2018
@fantasai
[css-scroll-snap] Add missing auto value to scroll-padding longhands. #…
abc1853 
…3189
@fantasai
Copy link
Collaborator

fantasai commented Oct 3, 2018

Good catch! Fixed, thanks so much for your attention to detail!!

@fantasai fantasai closed this as completed Oct 3, 2018
@ewilligers
Copy link
Contributor Author

Two shorthands still need fixing:

  • scroll-padding-block
  • scroll-padding-inline

@ewilligers ewilligers reopened this Oct 4, 2018
fantasai added a commit that referenced this issue Oct 5, 2018
@fantasai
[css-scroll-snap] Fix missing auto value in scroll-padding-inline/blo…
5dfc463 
…ck shorthands. #3189
@fantasai
Copy link
Collaborator

fantasai commented Oct 5, 2018

OK, I think it's good now?

@ewilligers
Copy link
Contributor Author

The grammar for scroll-padding uses [ ].

I suspect scroll-padding-block and scroll-padding-inline need square brackets to, so they can accept auto 10px and 10px auto and auto auto.

fantasai added a commit that referenced this issue Oct 8, 2018
@fantasai
[css-scroll-snap-1] Fix scroll-padding-inline/block grammar ad hope e…
622c8f1 
…willigers don't hate me yet for screwing this up so many times. #3189
@fantasai
Copy link
Collaborator

fantasai commented Oct 8, 2018 •
edited
Loading

Man, even typoed the commit message and included a grammar error. I can't do anything right in this issue. T_T

Is the spec correct yet, @ewilligers ?

@ewilligers
Copy link
Contributor Author

Looks good, thank you.

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2018
@sunyunjia @chromium-wpt-export-bot
Update scroll-padding initial values in wpt tests.
4c95390 
There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
aarongable pushed a commit to chromium/chromium that referenced this issue Oct 25, 2018
@sunyunjia
Update scroll-padding initial values in wpt tests.
8689480 
There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2018
@sunyunjia @chromium-wpt-export-bot
Update scroll-padding initial values in wpt tests.
be749ce 
There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2018
@sunyunjia @chromium-wpt-export-bot
Update scroll-padding initial values in wpt tests.
f5832cc 
There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 10, 2018
@sunyunjia @moz-wptsync-bot
Bug 1502231 [wpt PR 13726] - Update scroll-padding initial values in …
fa7c233 
…wpt tests., a=testonly

Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.

There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}

--

wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726
jyc pushed a commit to jyc/gecko that referenced this issue Nov 11, 2018
@sunyunjia @moz-wptsync-bot
Bug 1502231 [wpt PR 13726] - Update scroll-padding initial values in …
492e09d 
…wpt tests., a=testonly

Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.

There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602929}

--

wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1502231 [wpt PR 13726] - Update scroll-padding initial values in …
0968b24 
…wpt tests., a=testonly

Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.

There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Sandra Sun <sunyunjiachromium.org>
Cr-Commit-Position: refs/heads/master{#602929}

--

wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726

UltraBlame original commit: 0c38efcf9019977d782b091fd98d0556a986b4b0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1502231 [wpt PR 13726] - Update scroll-padding initial values in …
437eba7 
…wpt tests., a=testonly

Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.

There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Sandra Sun <sunyunjiachromium.org>
Cr-Commit-Position: refs/heads/master{#602929}

--

wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726

UltraBlame original commit: 0c38efcf9019977d782b091fd98d0556a986b4b0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1502231 [wpt PR 13726] - Update scroll-padding initial values in …
98dd923 
…wpt tests., a=testonly

Automatic update from web-platform-testsUpdate scroll-padding initial values in wpt tests.

There was a conflict in the scroll snap spec for the initial values of
scroll-padding-top/bottom/left/right[1]. Some of the initial values were
auto, while others were 0px. Now the conflict has been resolved with
all the initial values set to auto[2], we should update the wpt test to
reflect that.

The current implementation in Blink already reflects the updated spec,
so this patch also removes the expectations that were simply for the
failures.
[1] w3c/csswg-drafts#3189
[2]
https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top

Bug: 891954
Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2
Reviewed-on: https://chromium-review.googlesource.com/c/1299605
Reviewed-by: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Sandra Sun <sunyunjiachromium.org>
Cr-Commit-Position: refs/heads/master{#602929}

--

wpt-commits: f5832ccdb3c303d03565d391ed7ce3bf9719f5c1
wpt-pr: 13726

UltraBlame original commit: 0c38efcf9019977d782b091fd98d0556a986b4b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-scroll-snap-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fantasai @ewilligers