Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shapes] Accept percentage for shape-image-threshold #4102

Closed
BorisChiou opened this issue Jul 10, 2019 · 2 comments · Fixed by #4151
Closed

[css-shapes] Accept percentage for shape-image-threshold #4102

BorisChiou opened this issue Jul 10, 2019 · 2 comments · Fixed by #4151
Labels
Closed Accepted by CSSWG Resolution css-shapes-1 Current Work

Comments

@BorisChiou
Copy link
Contributor

BorisChiou commented Jul 10, 2019 •
edited
Loading

The current spec of shape-image-threshold uses <number> as its value. However, it seems this property is also kind of alpha value, and #3342 suggests we add <percentage> for opacity related properties. Therefore, I just wonder should we update shape-image-threshold to accept <alpha-value>?

cc @ericwilligers @emilio
@ewilligers
Copy link
Contributor

No objections.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Accept percentage for shape-image-threshold, and agreed to the following:

  • RESOLVED: Treat shape-image-threshold as an opacity prop and allow %
The full IRC log of that discussion <dael> Topic: Accept percentage for shape-image-threshold
<dael> github: https://github.com//issues/4102
<dael> emilio: Recently gecko added alpha value syntax. shape-image-threshold takes an alpha makes sense
<dael> astearns: Makes sense to me. Any concerns?
<dael> astearns: Prop: Treat shape-image-threshold as an opacity prop and allow %
<dael> RESOLVED: Treat shape-image-threshold as an opacity prop and allow %

@mozilla-apprentice mozilla-apprentice mentioned this issue Jul 24, 2019
Closed
ewilligers pushed a commit to ewilligers/csswg-drafts that referenced this issue Jul 25, 2019
@ericwilligers
[css-shapes] shape-image-threshold accepts percent
91fe4f2 
shape-image-threshold now accepts any alpha-value, just like
opacity. (An alpha-value is a number or percentage, that
serializes as a number.)

resolves w3c#4102
@ewilligers ewilligers mentioned this issue Jul 25, 2019
Merged
This was referenced Feb 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution css-shapes-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-shapes] shape-image-threshold accepts percent ewilligers/csswg-drafts
6 participants
@ewilligers @emilio @astearns @BorisChiou @cdoublev @css-meeting-bot