Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ruby-1] Rename ruby-merge: collapse to ruby-merge: merge #5004

Closed
fantasai opened this issue Apr 24, 2020 · 3 comments
Closed

[css-ruby-1] Rename ruby-merge: collapse to ruby-merge: merge #5004

fantasai opened this issue Apr 24, 2020 · 3 comments
Labels
Closed Accepted by CSSWG Resolution css-ruby-1 Current Work i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. Tested Memory aid - issue has WPT tests

Comments

@fantasai
Copy link
Collaborator

fantasai commented Apr 24, 2020

From @r12a

http://www.w3.org/TR/css-ruby-1/#collapsed-ruby
4.2 Sharing Annotation Space: the ruby-merge property

If the ruby-merge property is to remain, i think that a better name for 
the `collapse` value would be `merge`, ie.
ruby-merge: merge;

The meaning of `collapse` is not as obvious as `merge`, to my mind.

This issue is also tracked as Issue 44 in the DoC

@xfq xfq added the i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. label Apr 25, 2020
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed ruby-merge name, and agreed to the following:

  • RESOLVED: rename ruby-merge to merge
  • RESOLVED: rename collapse value to merge
The full IRC log of that discussion <fantasai> Topic: ruby-merge name
<fantasai> https://github.com//issues/5004
<fantasai> github: https://github.com//issues/5004
<dael> fantasai: Rename collapse value of ruby-merge to merge. Can we resolve?
<dael> florian: Not implemented?
<dael> fantasai: Not that I know of
<dael> florian: IN favor
<dael> fantasai: I don't care
<dael> astearns: We can resolve bc no one cares
<fantasai> https://www.w3.org/TR/css-ruby-1/#collapsed-ruby
<dael> astearns: Objections to rename ruby-merge to merge
<fantasai> ruby-merge: separate | collapse | auto
<fantasai> collapse -> merge
<dael> myles: Request that editor adds pictures to this section os spec
<dael> fantasai: Fair
<dael> RESOLVED: rename ruby-merge to merge
<fantasai> s/ruby-merge/collapse
<astearns> RESOLVED: rename collapse value to merge

@frivoal frivoal added Needs Testcase (WPT) Testing Unnecessary Memory aid - issue doesn't require tests and removed Needs Edits Needs Testcase (WPT) labels May 14, 2020
frivoal added a commit to frivoal/wpt that referenced this issue May 14, 2020
frivoal added a commit to web-platform-tests/wpt that referenced this issue May 14, 2020
@frivoal frivoal added Tested Memory aid - issue has WPT tests and removed Testing Unnecessary Memory aid - issue doesn't require tests labels May 14, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 26, 2020
…e property, a=testonly

Automatic update from web-platform-tests
[css-ruby] test parsing of the ruby-merge property (#23591)

See w3c/csswg-drafts#5004
--

wpt-commits: 48950262c7bfde62ce876471f354b878b06958ce
wpt-pr: 23591
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 26, 2020
…e property, a=testonly

Automatic update from web-platform-tests
[css-ruby] test parsing of the ruby-merge property (#23591)

See w3c/csswg-drafts#5004
--

wpt-commits: 48950262c7bfde62ce876471f354b878b06958ce
wpt-pr: 23591
@r12a
Copy link
Contributor

r12a commented Feb 5, 2021

Thank you.

@r12a r12a added i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. and removed i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. labels Feb 5, 2021
@r12a
Copy link
Contributor

r12a commented Feb 5, 2021

Changed the labels to bring in synch with #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution css-ruby-1 Current Work i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. Tested Memory aid - issue has WPT tests
Projects
None yet
Development

No branches or pull requests

6 participants