-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text] Editorial nit for example 8 #5024
Comments
On the one hand, you're right that it's not visually obvious there's not an extra space for people who don't know that this punctuation sign is a wide one. On the other hand, this example demonstrates that the segment break transformation works fine with punctuation marks at the end of the line, and making the change you suggest would loose that. |
Yes, i figured that was why you did it, but it seemed to me that the disadvantage for most readers outweighted the advantage for those with enough awareness to interpret correctly what was happening. |
Maybe we can replace the |
Mmm. It's not centred in Simplified Chinese, only Traditional, eg. go here and select a SC font. (You may find this table useful) Also, this doesn't currently work as expected with all punctuation. For example, if you swap the Btw, there's also a typo in the flattened version: missing 写. |
Also, the markup for the example doesn't have a
These being han characters, that may lead to some unpredictable results for readers, because different browsers apply different fonts by default - could be SC, TC, or JA. |
and
Fixed: 3fc4268 |
I think having the example handle punctuation is good; the second line already shows the case between two Letters.
@r12a, If you want to discuss this comment, please file it separately. We do already have a related discussion in #5017 But a few points to note: we've been asked by some implementers to keep things block-by-block since this code is "hot", and we've been asked to avoid switching behavior based on language (which has bad implications for both perf and portability). |
So, other than the fixes already made and mentioned in #5024 (comment), the proposal would be to close this with no change, the rationale being that while it may not be immediately visually obvious to the non trained eye what's going on, trained/careful eyes will understand, and it is better for the example to cover this situation than not. @r12a is that acceptable to you? |
I was just trying to say that
is only true for some punctuation. |
Then my suggestion would be to replace the zh-Hans language tag with zh-Hant. That will produce a centred punctuation, which still makes the point but is (slightly) less open to the possible misunderstanding we started with. I'd be happier if you made that change, but i leave it up to you. |
Switching to zh-Hant seems like a reasonable compromise, I'll do that. |
4.1.3. Segment Break Transformation Rules
https://drafts.csswg.org/css-text-3/#line-break-transform
Example 8.
I think the line break after the first line of the Chinese example is unfortunate, because the untrained eye won't be able to immediately detect that the line-break wasn't turned into a space (line ends with ,). Why not pull 在 up onto the first line?
The text was updated successfully, but these errors were encountered: