Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-inline-3] shape-margin on initial-letters-wrap: first #5117

Closed
fantasai opened this issue May 27, 2020 · 6 comments
Closed

[css-inline-3] shape-margin on initial-letters-wrap: first #5117

fantasai opened this issue May 27, 2020 · 6 comments

Comments

@fantasai
Copy link
Collaborator

In #4171 we resolved to apply 'shape-margin' to the glyph outline for initial-letters-wrap: all. What about the first line of initial-letters-wrap: first?

CC @dauwhe @faceless2

@fantasai fantasai added the css-inline-3 Current Work label May 27, 2020
@fantasai
Copy link
Collaborator Author

Another related case to consider: the glyph outline of descenders that expand outside the initial-letter’s box.

@faceless2
Copy link

I think it needs to apply to any case where the margin is derived from the outline of the letter - so yes, it should apply to the first line of initial-letters-wrap: first and around the descenders.

@fantasai
Copy link
Collaborator Author

SGTM. Let's ask the WG. :)

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed shape-margin on initial-letters-wrap: first, and agreed to the following:

  • RESOLVED: shape-margin and shape-outside apply to initial letter wrapped inline boxes, modifying or replacing the shape of the glyph
The full IRC log of that discussion <heycam> Topic: shape-margin on initial-letters-wrap: first
<heycam> github: https://github.com//issues/5117
<heycam> fantasai: we resolved to allow shape-margin that wraps around the glyph, and wrapps all the lines around the shape
<heycam> ... the other values of initial-letter. one is first, which pulls the first line in and wraps it
<heycam> ... the suggestion was if we apply a shape margin to all lines when wrapping to the glyph shape, shouldn't you also allow it when wrapping the first line to it
<jensimmons> +1 from me to this
<heycam> ... proposal is to make shape-margin apply whenever you are wrapping to the glyph shape
<heycam> Rossen_: currently it's defined only to apply to floats
<heycam> fantasai: we should probably update to say it also applies to initial letter boxes
<astearns> +1 from me
<heycam> ... then define exactly how that works in initial-letter-wrap
<heycam> dbaron: presumably you want the same wording that you have for 'all'?
<heycam> ... [reads some spec text]
<heycam> fantasai: makes sense to me. apply shape-outside and shape-margin, and use that as a replacement of the glyph shape
<heycam> faceless2_: I agree that makes sense
<florian> +1
<dbaron> What I read was "If the value of shape-outside is not none, shape-outside is used instead of the glyph outline. In both cases, shape-margin is applied to expand the outline."
<dbaron> ... from https://drafts.csswg.org/css-inline-3/#valdef-initial-letters-wrap-all
<heycam> RESOLVED: shape-margin and shape-outside apply to initial letter wrapped inline boxes, modifying or replacing the shape of the glyph

@fantasai
Copy link
Collaborator Author

fantasai commented Jun 4, 2020

Turns out no edits are necessary, since first defines itself in terms of none and all. ^_^

@fantasai
Copy link
Collaborator Author

fantasai commented Jun 4, 2020

Filed #5160 on updating the css-shapes-1 propdefs (not directly about this issue, but mentioned in the WG discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants